fix: response code for cluster template deletion webhook #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description If open-edge-platform/cluster-connect-gateway#7 PR with metrics enablement is getting merged following PR with changes to template needs to introduced
Co-authored-by: Togashi, Denisio <denisio.togashi@intel.com>
jokuniew
requested review from
gcgirish,
andybavier,
hyunsun,
jdanieck and
sys-orch-approve
as code owners
jdanieck
approved these changes
May 8, 2025
gcgirish
approved these changes
May 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
gcgirish
approved these changes
May 12, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
pierventre
pushed a commit
that referenced
this pull request
May 17, 2025
Co-authored-by: pbartosik <pawelbrtsk@gmail.com> Co-authored-by: Kasprzak, Mikolaj <mikolaj.kasprzak@intel.com> Co-authored-by: Aaron Dorney <85556203+adorney99@users.noreply.github.com> Co-authored-by: Jozef Daniecki <jozef.daniecki@intel.com> Co-authored-by: Togashi, Denisio <denisio.togashi@intel.com> Co-authored-by: Paulina-Osikoya <Paulina.Osikoya@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump version of cluster-manager with correct response for webhook - once used try to delete template that is used by cluster - cm should return 409 instead of 500
Any Newly Introduced Dependencies
none
How Has This Been Tested?
mage test:ClusterOrchSmokeTest
Checklist: