-
Notifications
You must be signed in to change notification settings - Fork 7
CO: enable advanced CAPI providers configuration #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! Please make sure to review our Contributing Guide.
This reverts commit 0abefdf.
57b0ef1
to
5006d05
Compare
togashidm
approved these changes
Apr 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
charlesmcchan
approved these changes
Apr 24, 2025
andybavier
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this PR Cluster API Operator helm chart was used to deploy both the CAPI operator and the CAPI providers configuration CRs.
The helm chart exposes only limited configuration which is not sufficient for our current needs (e.g. we need the ability to provide custom image or configure metrics). Because of that we will use official operator helm chart to deploy operator only and our custom helm chart to configure CAPI providers CRs.
Any Newly Introduced Dependencies
No new 3rd party dependencies.
How Has This Been Tested?
Deployed Orchestrator from co-capi-providers-configuration branch on Coder.
Checklist: