fix: response code for cluster template deletion webhook (#278)

Co-authored-by: pbartosik <pawelbrtsk@gmail.com>
Co-authored-by: Kasprzak, Mikolaj <mikolaj.kasprzak@intel.com>
Co-authored-by: Aaron Dorney <85556203+adorney99@users.noreply.github.com>
Co-authored-by: Jozef Daniecki <jozef.daniecki@intel.com>
Co-authored-by: Togashi, Denisio <denisio.togashi@intel.com>
Co-authored-by: Paulina-Osikoya <Paulina.Osikoya@intel.com>

Author: 7 people

argocd/applications/templates/cluster-manager.yaml

@@ -21,7 +21,7 @@ spec:
   sources:
     - repoURL: {{ required "A valid chartRepoURL entry required!" .Values.argo.chartRepoURL }}
       chart: cluster/charts/{{$appName}}
-      targetRevision: 2.1.0
+      targetRevision: 2.1.1-dev-ddee31c6
       helm:
         releaseName: {{$appName}}
         valuesObject:
@@ -33,7 +33,7 @@ spec:
           {{- mergeOverwrite $baseConfig $customConfig $overwrite | toYaml | nindent 10 }}
     - repoURL: {{ required "A valid chartRepoURL entry required!" .Values.argo.chartRepoURL }}
       chart: cluster/charts/cluster-template-crd
-      targetRevision: 2.1.0
+      targetRevision: 2.1.1-dev-ddee31c6
   destination:
     namespace: {{$namespace}}
     server: {{ required "A valid targetServer entry required!" .Values.argo.targetServer }}

e2e-tests/orchestrator/clusterorch_smoke_test.go

@@ -456,9 +456,9 @@ var _ = Describe("Cluster Orch Smoke Test", Ordered, Label(clusterOrchSmoke), fu
 			Expect(err).ToNot(HaveOccurred())
 			fmt.Println(string(body))
 
-			// Expect the request to fail with a 500 Internal Server Error status code
-			Expect(resp.StatusCode).To(Equal(http.StatusInternalServerError), "Expected 500 Internal Server Error when deleting a template in use")
-			Expect(body).To(ContainSubstring("denied the request: clusterTemplate is in use"))
+			// Expect the request to fail with a 409 Conflict status code
+			Expect(resp.StatusCode).To(Equal(http.StatusConflict), "Expected 409 Conflict when deleting a template in use")
+			Expect(body).To(ContainSubstring("clusterTemplate is in use"))
 			fmt.Printf("Failed to delete template %s-%s as expected, HTTP status code: %d\n", defaultTemplateName, defaultTemplateVersion, resp.StatusCode)
 		})
 	})