Refactor existing native composite types/values to use CompositeType and CompositeValue #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupunS
force-pushed
the
supun/refactor-native-types-0
branch
from
dbd6b00
to
6739995
Compare
6 tasks
SupunS
force-pushed
the
supun/refactor-native-types-0
branch
from
d725d22
to
90d63df
Compare
|
Thank you for cleaning this up @SupunS! Would it be OK if we would wait and merge this into the next major release? It's a big change and it might be good to only merge minor fixes for now |
|
@turbolent yes, that would be a good idea. I will see if there are other possible types we could refactor, and get them in too. Then maybe we could push everything at once. |
SupunS
force-pushed
the
supun/refactor-native-types-0
branch
from
90d63df
to
534a83c
Compare
turbolent
reviewed
Apr 1, 2021
| @@ -5278,6 +5278,7 @@ type CompositeValue struct { | |||
| Owner *common.Address | |||
| destroyed bool | |||
| modified bool | |||
| stringer func() string | |||
| } | ||
|
|
||
| payerAddress := payerAddressValue.(interpreter.AddressValue).ToAddress() |
| }() | ||
|
|
||
| func init() { | ||
| // Set the container type after initializing the `AuthAccountContractsType`, to avoid initializing loop. |
SupunS
force-pushed
the
supun/refactor-native-types-0
branch
from
534a83c
to
310976f
Compare
SupunS
force-pushed
the
supun/refactor-native-types-0
branch
from
eac96cc
to
79e464b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #650
Closes #661
Description
Some native composite values and types (e.g. AuthAccount, AuthAccount.Contracts, PublicAccount, etc.) are defined through separate Go types implementing the
Valueinterface (e.g. AuthAccountValue) andTypeinterface (e.g. AuthAccountType).This PR refactor those existing values and types to use
CompositeValueandCompositeTyperespectively.For contributor use:
masterbranchFiles changedin the Github PR explorer