Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor existing native composite values to use 'CompositeValue' #668

Closed
wants to merge 12 commits into from

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Mar 8, 2021

Closes #650
Closes #661

Description

Currently, native composite values and types (e.g. AuthAccount, AuthAccount.Contracts, PublicAccount, etc.) are defined through separate Go types implementing the Value interface (e.g. AuthAccountValue) and Type interface (e.g. AuthAccountType).

This PR refactor those existing values and types to use CompositeValue and CompositeType respectively.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS self-assigned this Mar 8, 2021
@SupunS SupunS mentioned this pull request Mar 12, 2021
6 tasks
@SupunS
Copy link
Member Author

SupunS commented Mar 16, 2021

Seems this PR has way too many conflicts to rebase. Hence opened a separate PR: #698

@SupunS SupunS closed this Mar 16, 2021
@SupunS SupunS deleted the supun/account-keys-4 branch March 17, 2021 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant