Add computed fields to the composite value #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbolent
approved these changes
Mar 5, 2021
| @@ -5341,6 +5342,8 @@ type CompositeValue struct { | |||
| modified bool | |||
| } | |||
|
|
|||
| type ComputedField func(*Interpreter) Value | |||
There was a problem hiding this comment.
Good idea to introduce a type for this 👍
SupunS
added a commit
that referenced
this pull request
Mar 16, 2021
SupunS
added a commit
that referenced
this pull request
Mar 23, 2021
SupunS
added a commit
that referenced
this pull request
Apr 1, 2021
SupunS
added a commit
that referenced
this pull request
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #660
Working towards #650
Description
A computed field is a
func(*Interpreter) Valuefunction pointer. Invoking this function computes the value on the fly and returns it.A computed value takes an
*Interpreteras an argument, as computation of the value may rely on the interpreter.e.g: auth account fields
For contributor use:
masterbranchFiles changedin the Github PR explorer