Export big images as jpeg 10841 dev 4 4

[will-moore]

This is in develop as #31, now for dev_4_4...

[sbesson]

--rebased-from #31

[snoopycrimecop]

Conflicting PR. Removed from build OMERO-merge-stable#381. See theconsole output for more details.

[joshmoore]

@will-moore: did you get / can you see the notification re:

checking ./omero/export_scripts/Batch_Image_Export.py
./omero/export_scripts/Batch_Image_Export.py:390:17: E201 whitespace after '('
./omero/export_scripts/Batch_Image_Export.py:401:21: E201 whitespace after '('
./omero/export_scripts/Batch_Image_Export.py:402:80: E501 line too long (92 > 79 characters)
``` ?

[will-moore]

@joshmoore No - not that I'm aware of. Where should I be looking?

[joshmoore]

For me your c59a4ed commit has a red X linking to https://travis-ci.org/ome/scripts/builds/11824401

[will-moore]

Ah - OK, I see it. But the way I read it, the build failed (exited with 1) due to:

The command "flake8 -v ." exited with 1.
Done. Your build exited with 1.

so it took me a long time to spot the failing lines above.

Is it possible to up the limit on 79 characters? This seems kinda short, and often readability will be worse due to wrapping than if we had a slightly higher limit.

I see that omero.gateway/init.py PEP8 has 597 lines that are too long!

   7      E111 : indentation is not a multiple of four
   9      E201 : whitespace after '('
   5      E202 : whitespace before ')'
 350      E211 : whitespace before '('
   4      E222 : multiple spaces after operator
  86      E231 : missing whitespace after ':'
   1      E241 : multiple spaces after ','
  54      E301 : expected 1 blank line, found 2
  53      E302 : expected 2 blank lines, found 1
   2      E401 : multiple imports on one line
 597      E501 : line too long (102 characters)
   1      E701 : multiple statements on one line (colon)
   9      E702 : multiple statements on one line (semicolon)
 777      W291 : trailing whitespace
   9      W601 : .has_key() is deprecated, use 'in'

[joshmoore]

Shorter lines can also be made readable, though that's of course highly subjective. I'd tend to just strictly follow PEP8 rather than opening a discussion for various rules. Perhaps we go over this briefly at the next meeting?

/cc @cneves, @chris-allan, @aleksandra-tarkowska, @knabar, @ximenesuk, @jburel

[mtbc]

Yeah, restricting lines to under 80 columns seems a bit weird these days, it'd just make me pick short variable names. At least allow 132 columns. (-:

This PR seems to work well, and I think as intended.

I did find it unhelpful that if I select big image A and not-big image B, then try to do the batch export, it seems to go okay in the activities window and it's only if I look in the zip or peer carefully at the script output that I discover that A is omitted.

I also found it odd that, when no images are exported (because I selected only big images), for that script run I still get a green tick in the activities window.

[joshmoore]

@will-moore, @gusferguson -- are similar RFEs recorded elsewhere? I'll leave you to do so if not.

@mtbc: thanks. Merging.

[gusferguson]

@joshmoore @will-moore

I don't know of any similar RFEs

[will-moore]

@joshmoore Not sure if you meant to merge before I fixed the PEP8 errors above. Anyway - they've now been fixed in a new PR #49

[joshmoore]

Sorry about that, @will-moore. And thanks!