-
Notifications
You must be signed in to change notification settings - Fork 32
Activate Travis build and fix scripts to comply with flake8 standards #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looking at sbesson@b759912?w=1 is fairly readable. (Note the |
Conflicts: omero/export_scripts/Make_Movie.py omero/figure_scripts/Movie_Figure.py omero/figure_scripts/Movie_ROI_Figure.py omero/figure_scripts/ROI_Split_Figure.py omero/figure_scripts/Split_View_Figure.py omero/figure_scripts/Thumbnail_Figure.py
|
@will-moore, once this PR is accepted, I'll turn on travis for all of ome/scripts and then we'll have testing on every new PR. @sbesson : don't know if this is important but travis log includes: |
|
@joshmoore: good point. Fixed in the last 2 commits. |
|
Running Movie_ROI_Figure.py I get |
|
Same for Movie_Figure.py |
|
Having run almost all of the scripts at least once, the only errors I get are the two getLabels ones above, but I also found a problem with unwrapping parameters on Combine_Images.py, which I think is unrelated: Ticket created: https://trac.openmicroscopy.org.uk/ome/ticket/11473 |
|
OK - working now. Good to merge. |
|
@sbesson: did you want to wait for any rebasing due to the develop PR you mentioned? |
|
Up to @will-moore , the PR in question is #31 which needs/could be rebased on dev_4_4. |
|
@will-moore: 👍 thanks. I'm merging this. Could you rebase and rationalize the rebase with 45? I'll go ahead and activate the travis build for ome/scripts so that we'll see the test status in your rebased PR. |
Activate Travis build and fix scripts to comply with flake8 standards
|
--rebased-to #46 |
This PR adds a .travis.yml file at the top-level of the repository running
flake8on all the Python scripts. It also fixes individual scripts to comply with flake8 standards and let the Travis build pass.To test this PR: