Skip to content

Conversation

@sbesson
Copy link
Member

@sbesson sbesson commented Sep 25, 2013

This is the same as gh-41 but rebased onto develop.


This PR adds a .travis.yml file at the top-level of the repository running flake8 on all the Python scripts. It also fixes individual scripts to comply with flake8 standards and let the Travis build pass.

  • omero/analysis_scripts/Kymograph.py
  • omero/analysis_scripts/Kymograph_Analysis.py
  • omero/analysis_scripts/Plot_Profile.py
  • omero/export_scripts/Batch_Image_Export.py
  • omero/export_scripts/Make_Movie.py
  • omero/figure_scripts/Movie_Figure.py
  • omero/figure_scripts/Movie_ROI_Figure.py
  • omero/figure_scripts/ROI_Split_Figure.py
  • omero/figure_scripts/Split_View_Figure.py
  • omero/figure_scripts/Thumbnail_Figure.py
  • omero/import_scripts/Populate_ROI.py
  • omero/setup_scripts/FLIM_initialise.py
  • omero/util_scripts/Channel_Offsets.py
  • omero/util_scripts/Combine_Images.py
  • omero/util_scripts/Dataset_To_Plate.py
  • omero/util_scripts/Images_From_ROIs.py

To test this PR:

@sbesson
Copy link
Member Author

sbesson commented Sep 25, 2013

--rebased-from #41

@snoopycrimecop
Copy link
Member

Conflicting PR. Removed from build OMERO-merge-develop#422. See theconsole output for more details.

@sbesson
Copy link
Member Author

sbesson commented Sep 26, 2013

Yeay Travis is green :)

@will-moore
Copy link
Member

https://travis-ci.org/sbesson/scripts looks Red to me:

$ rake
rake aborted!
No Rakefile found (looking for: rakefile, Rakefile, rakefile.rb, Rakefile.rb)

@sbesson
Copy link
Member Author

sbesson commented Sep 27, 2013

https://travis-ci.org/ome/scripts/builds/11820688 is the correct link

@will-moore
Copy link
Member

https://travis-ci.org/ome/scripts/builds/11820688 is green ;)
And a quick test of a few scripts finds no problems.
Good to merge.

@joshmoore
Copy link
Member

Thanks, @will-moore. With this in, all new PRs should start going green.

joshmoore added a commit that referenced this pull request Sep 27, 2013
Activate Travis build and fix scripts to comply with flake8 standards (rebased onto develop)
@joshmoore joshmoore merged commit 43d8880 into ome:develop Sep 27, 2013
@sbesson sbesson deleted the rebased/develop/travis branch September 27, 2013 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants