Skip to content

Conversation

@sbesson
Copy link
Member

@sbesson sbesson commented Oct 3, 2013

This is the same as gh-49 but rebased onto develop.


Fix the last PEP8 issues noted in #45. Flake8 test should pass.

@sbesson
Copy link
Member Author

sbesson commented Oct 3, 2013

--rebased-from #49

@sbesson
Copy link
Member Author

sbesson commented Oct 3, 2013

NB: #49 has been included in develop as part of b00f440. But I realized the latter commit introduced an unwanted indent. This commit should fix this error and remove all drift between dev_4_4 and develop on this script

sebastien@jrs-macbookpro-25399:scripts ((10195f3...)) $ git diff origin/dev_4_4 sbesson/rebased/develop/export_Big_Images_as_jpeg_10841_dev_4_4 -- omero/export_scripts/Batch_Image_Export.py
sebastien@jrs-macbookpro-25399:scripts ((10195f3...)) $ 

@sbesson
Copy link
Member Author

sbesson commented Oct 4, 2013

To test this PR, run the script on an image and then check the script log once the script finishes successfully.
The log should include Saving planes from image: xxx

@pwalczysko
Copy link
Member

Works as expected. Ready to merge.

joshmoore added a commit that referenced this pull request Oct 4, 2013
…_as_jpeg_10841_dev_4_4

Export big images as jpeg 10841 dev 4 4 (rebased onto develop)
@joshmoore joshmoore merged commit f3a96d7 into ome:develop Oct 4, 2013
@sbesson sbesson deleted the rebased/develop/export_Big_Images_as_jpeg_10841_dev_4_4 branch October 4, 2013 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants