Skip to content

Conversation

@taherkl
Copy link

@taherkl taherkl commented Jan 28, 2025

No description provided.

shreyakhajanchi and others added 5 commits January 23, 2025 15:29
* testing flaky change

* restoring old timeout

* increasing timeout
* fix: revamp Neo4j kernel version sniffing

Neo4j switches to calver-versioning very soon, so trying to
exactly match a version is not gonna work properly anymore.

This commit changes the version parsing logic, to make versions
comparable (e.g.: Version(2025,1) > Version(5, 26, 0)).

This also fixes a bunch of inaccuracies of some of the
capability checks.

* test: address review comments

* fix: tests
Copy link
Collaborator

@pawankashyapollion pawankashyapollion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taherkl taherkl merged commit 5d5f1a8 into ollionorg:main Jan 28, 2025
5 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants