Skip to content

Conversation

@fbiville
Copy link
Collaborator

Neo4j switches to calver-versioning very soon, so trying to exactly match a version is not gonna work properly anymore.

This commit changes the version parsing logic, to make versions comparable (e.g.: Version(2025,1) > Version(5, 26, 0)).

This also fixes a bunch of inaccuracies of some of the capability checks.

Neo4j switches to calver-versioning very soon, so trying to
exactly match a version is not gonna work properly anymore.

This commit changes the version parsing logic, to make versions
comparable (e.g.: Version(2025,1) > Version(5, 26, 0)).

This also fixes a bunch of inaccuracies of some of the
capability checks.
@fbiville fbiville force-pushed the neo4j/version_parsing branch from 9a4b43a to b82c5df Compare January 24, 2025 14:06
@fbiville fbiville force-pushed the neo4j/version_parsing branch from 5b79e9d to af91307 Compare January 24, 2025 14:46
@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 81.69014% with 13 lines in your changes missing coverage. Please review.

Project coverage is 46.86%. Comparing base (a51c096) to head (1c6a06d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../teleport/v2/neo4j/database/Neo4jCapabilities.java 77.96% 7 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2148      +/-   ##
============================================
+ Coverage     46.83%   46.86%   +0.02%     
- Complexity     4004     4006       +2     
============================================
  Files           874      874              
  Lines         51987    52026      +39     
  Branches       5441     5451      +10     
============================================
+ Hits          24349    24380      +31     
- Misses        25899    25904       +5     
- Partials       1739     1742       +3     
Components Coverage Δ
spanner-templates 68.77% <ø> (+0.01%) ⬆️
spanner-import-export 65.57% <ø> (+0.03%) ⬆️
spanner-live-forward-migration 76.50% <ø> (ø)
spanner-live-reverse-replication 78.66% <ø> (ø)
spanner-bulk-migration 87.87% <ø> (ø)
Files with missing lines Coverage Δ
...ud/teleport/v2/neo4j/database/Neo4jConnection.java 75.24% <100.00%> (-0.25%) ⬇️
.../teleport/v2/neo4j/database/Neo4jCapabilities.java 80.82% <77.96%> (-4.03%) ⬇️

... and 2 files with indirect coverage changes

@fbiville fbiville force-pushed the neo4j/version_parsing branch from af91307 to 1c6a06d Compare January 24, 2025 16:04
@liferoad liferoad merged commit 7a4ebad into GoogleCloudPlatform:main Jan 24, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants