Skip to content

Conversation

@hengfengli
Copy link
Contributor

@hengfengli hengfengli commented Jan 23, 2025

This fixes two issues:

  • The sequence option default is not added correctly when exporting sequences.
  • We should use tableName instead of tableSchema when calling GET_TABLE_COLUMN_IDENTITY_STATE.

@hengfengli hengfengli requested a review from a team as a code owner January 23, 2025 05:32
@codecov
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.84%. Comparing base (6638feb) to head (a019dbd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2146      +/-   ##
============================================
+ Coverage     46.75%   46.84%   +0.09%     
- Complexity     3978     4007      +29     
============================================
  Files           873      874       +1     
  Lines         51871    51987     +116     
  Branches       5429     5441      +12     
============================================
+ Hits          24251    24355     +104     
- Misses        25894    25895       +1     
- Partials       1726     1737      +11     
Components Coverage Δ
spanner-templates 68.78% <100.00%> (+0.14%) ⬆️
spanner-import-export 65.59% <100.00%> (ø)
spanner-live-forward-migration 76.50% <ø> (+0.01%) ⬆️
spanner-live-reverse-replication 78.66% <ø> (+0.26%) ⬆️
spanner-bulk-migration 87.87% <ø> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
...oud/teleport/spanner/AvroSchemaToDdlConverter.java 83.56% <100.00%> (ø)

... and 7 files with indirect coverage changes

@VardhanThigle VardhanThigle merged commit a51c096 into GoogleCloudPlatform:main Jan 24, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants