Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with Open API spec v2.2.1 #484

Merged
merged 22 commits into from
Dec 2, 2020

Conversation

sergiishamrai-okta
Copy link
Contributor

@sergiishamrai-okta sergiishamrai-okta commented Nov 17, 2020

Issue(s)

OKTA-345725

Description

Sync with Open API Spec v2.2.1

Category

  • Enhancement
  • Unit Test(s)
  • Documentation

@sergiishamrai-okta sergiishamrai-okta marked this pull request as draft November 17, 2020 09:37
@codecov-io
Copy link

codecov-io commented Nov 19, 2020

Codecov Report

Merging #484 (c093520) into master (c5a80d2) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #484   +/-   ##
=========================================
  Coverage     81.11%   81.12%           
  Complexity      979      979           
=========================================
  Files           122      122           
  Lines          3273     3274    +1     
  Branches        414      415    +1     
=========================================
+ Hits           2655     2656    +1     
  Misses          429      429           
  Partials        189      189           
Impacted Files Coverage Δ Complexity Δ
...ta/sdk/impl/resource/OktaResourceHrefResolver.java 90.00% <0.00%> (+0.34%) 12.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5a80d2...c093520. Read the comment docs.

@arvindkrishnakumar-okta
Copy link
Contributor

arvindkrishnakumar-okta commented Nov 25, 2020

I don't see the below changes imported in this PR:

Also, recommend double checking the diff of Java SDK's local spec copy with the latest open api spec to ensure we did not miss any.

Add missing fields
New interfaces are listed in the file
@sergiishamrai-okta
Copy link
Contributor Author

All incompatibilities are listed here

@arvindkrishnakumar-okta
Copy link
Contributor

I don't see the below changes imported in this PR:

* [okta/openapi#278](https://github.com/okta/openapi/pull/278)

* [okta/openapi#272](https://github.com/okta/openapi/pull/272)

Are these changes pulled in?

@sergiishamrai-okta
Copy link
Contributor Author

I don't see the below changes imported in this PR:

* [okta/openapi#278](https://github.com/okta/openapi/pull/278)

* [okta/openapi#272](https://github.com/okta/openapi/pull/272)

Are these changes pulled in?

Yes,
okta/openapi#278 is here, here and here

okta/openapi#272 is here

@sergiishamrai-okta sergiishamrai-okta merged commit 3528361 into master Dec 2, 2020
@arvindkrishnakumar-okta arvindkrishnakumar-okta deleted the okta-345725-open-api-v2.2.1 branch January 29, 2021 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants