Skip to content

Commit

Permalink
Add missing methods and update ITs
Browse files Browse the repository at this point in the history
  • Loading branch information
sergiishamrai-okta committed Nov 23, 2020
1 parent ec52cf0 commit 0144a09
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ class GroupsIT extends ITSupport implements CrudTestSupport {
validateGroup(group, groupName)

// 2. Search the group by name
assertPresent(client.listGroups(groupName, null), group)
assertPresent(client.listGroups(groupName, null, null), group)
}

@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,7 @@ class UsersIT extends ITSupport implements CrudTestSupport {
Role role = user.assignRole(assignRoleRequest)

// 3. Add Group Target to User Admin Role
user.addGroupTarget(role.id, group.id)
user.addGroupTarget(role.getId(), group.getId())

// 4. List Group Targets for Role
assertGroupTargetPresent(user, group, role)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ trait ClientProvider implements IHookable {

void deleteGroup(String groupName, Client client) {
Util.ignoring(ResourceException) {
GroupList groups = client.listGroups(groupName, null)
GroupList groups = client.listGroups(groupName, null, null)
groups.each {group ->
if (groupName.equals(group.profile.name)) {
group.delete()
Expand Down
16 changes: 16 additions & 0 deletions src/swagger/api.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2278,6 +2278,12 @@ paths:
in: query
name: limit
type: integer
- description: >-
If specified, it causes additional metadata to be included in the
response.
in: query
name: expand
type: string
produces:
- application/json
responses:
Expand Down Expand Up @@ -10074,6 +10080,8 @@ definitions:
type: string
issuer_mode:
$ref: '#/definitions/OpenIdConnectApplicationIssuerMode'
jwks:
$ref: '#/definitions/OpenIdConnectApplicationSettingsClientKeys'
logo_uri:
type: string
policy_uri:
Expand All @@ -10096,6 +10104,14 @@ definitions:
type: string
x-okta-tags:
- Application
OpenIdConnectApplicationSettingsClientKeys:
properties:
keys:
items:
$ref: '#/definitions/JsonWebKey'
type: array
x-okta-tags:
- Application
OpenIdConnectApplicationSettingsRefreshToken:
properties:
leeway:
Expand Down

0 comments on commit 0144a09

Please sign in to comment.