Skip to content

Commit

Permalink
Add missing methods and update ITs
Browse files Browse the repository at this point in the history
  • Loading branch information
sergiishamrai-okta committed Nov 23, 2020
1 parent 1ad7eca commit 821793f
Show file tree
Hide file tree
Showing 5 changed files with 27 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ class AuthorizationServerIT extends ITSupport {
assertThat(createdPolicyRule, notNullValue())
assertThat(createdPolicyRule.getType(), equalTo(AuthorizationServerPolicyRule.TypeEnum.ACCESS))

retrievedPolicy.deletePolicyRule(createdAuthorizationServer.getId(), createdPolicyRule.getId())
createdPolicyRule.deletePolicyRule(createdAuthorizationServer.getId())

// delete may not effect immediately in the backend
sleep(getTestOperationDelay())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ class GroupsIT extends ITSupport implements CrudTestSupport {
validateGroup(group, groupName)

// 2. Search the group by name
assertPresent(client.listGroups(groupName, null), group)
assertPresent(client.listGroups(groupName, null, null), group)
}

@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,7 @@ class UsersIT extends ITSupport implements CrudTestSupport {
Role role = user.assignRole(assignRoleRequest)

// 3. Add Group Target to User Admin Role
user.addGroupTarget(role.id, group.id)
user.addGroupTarget(role.getId(), group.getId())

// 4. List Group Targets for Role
assertGroupTargetPresent(user, group, role)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ trait ClientProvider implements IHookable {

void deleteGroup(String groupName, Client client) {
Util.ignoring(ResourceException) {
GroupList groups = client.listGroups(groupName, null)
GroupList groups = client.listGroups(groupName, null, null)
groups.each {group ->
if (groupName.equals(group.profile.name)) {
group.delete()
Expand Down
23 changes: 23 additions & 0 deletions src/swagger/api.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2278,6 +2278,12 @@ paths:
in: query
name: limit
type: integer
- description: >-
If specified, it causes additional metadata to be included in the
response.
in: query
name: expand
type: string
produces:
- application/json
responses:
Expand Down Expand Up @@ -7662,6 +7668,16 @@ definitions:
- dest: policyId
src: id
operationId: getAuthorizationServerPolicy
- alias: updatePolicy
arguments:
- dest: policyId
src: id
operationId: updateAuthorizationServerPolicy
- alias: deletePolicy
arguments:
- dest: policyId
src: id
operationId: deleteAuthorizationServerPolicy
x-okta-operations:
- alias: listPolicyRules
arguments:
Expand Down Expand Up @@ -7730,6 +7746,13 @@ definitions:
- dest: policyId
parentSrc: id
operationId: updateAuthorizationServerPolicyRule
- alias: deletePolicyRule
arguments:
- dest: ruleId
src: id
- dest: policyId
parentSrc: id
operationId: deleteAuthorizationServerPolicyRule
x-okta-operations:
- alias: activate
arguments:
Expand Down

0 comments on commit 821793f

Please sign in to comment.