Fix tab order on Create Group buttons #393
Conversation
| } | ||
|
|
||
| &.field.is-grouped > .control:not(:last-child) { | ||
| margin-left: 0.75rem; |
There was a problem hiding this comment.
I would replace this 0.75rem for the correct variable to avoid hardcoded code. $control-padding-horizontal following Bulma docs.
Besides that cool stuff!
There was a problem hiding this comment.
Indeed, as this could turn out to be something that gets adjusted in themes as well.
There was a problem hiding this comment.
I actually copied this from the bulma source: https://github.com/jgthms/bulma/blob/master/sass/elements/form.sass#L479 and just switched the direction. so in non-gi-specific grouped fields, that padding will always be 0.75rem and won't be adjusted by any variable.
I agree, It would totally make more sense to use a variable here, but then it wouldn't be consistent with other similar bulma classes.
so, should I still proceed and change this to a var?
| <button | ||
| class="button is-light is-large" | ||
| @click="prev" | ||
| :disabled="!this.currentStep" |
There was a problem hiding this comment.
While we're at it... who is fixing this v-if / :disabled conflict?
hubudibu
force-pushed
the
fix/createGroup-theme
branch
from
3b3e0fd to
eeb5ea7
Compare
since the recent theme updates, tabbing out from the group creation step input fields goes to the back button first, instead of the next button. fixing this (and an input field width) while trying to follow our new css conventions.