Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tab order on Create Group buttons #393

Merged
merged 2 commits into from
May 7, 2018
Merged

Fix tab order on Create Group buttons #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
599d795
fix: create group button order
hubudibu Apr 30, 2018
eeb5ea7
expand mincome field
hubudibu Apr 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/simple/components/Group/GroupMincome.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
</select>
</span>
</div>
<div class="control">
<div class="control is-expanded">
<input
class="input is-large is-primary"
:class="{ 'is-danger': v.incomeProvided.$error }"
Expand Down
15 changes: 15 additions & 0 deletions frontend/simple/sass/bulma_overrides/elements/form.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,18 @@
color: rgba($input-color, 0.4); // To improve A11Y
}
}

.gi- {
&is-grouped-reverse {
flex-direction: row-reverse;

&.field.is-grouped-right {
justify-content: flex-start;
}

&.field.is-grouped > .control:not(:last-child) {
margin-left: 0.75rem;
Copy link
Contributor

@sandrina-p sandrina-p May 1, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would replace this 0.75rem for the correct variable to avoid hardcoded code. $control-padding-horizontal following Bulma docs.

Besides that cool stuff!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, as this could turn out to be something that gets adjusted in themes as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually copied this from the bulma source: https://github.com/jgthms/bulma/blob/master/sass/elements/form.sass#L479 and just switched the direction. so in non-gi-specific grouped fields, that padding will always be 0.75rem and won't be adjusted by any variable.

I agree, It would totally make more sense to use a variable here, but then it wouldn't be consistent with other similar bulma classes.

so, should I still proceed and change this to a var?

margin-right: 0;
}
}
}
2 changes: 1 addition & 1 deletion frontend/simple/views/CreateGroup.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
</router-view>
</transition>

<div class="field is-grouped is-grouped-right form-actions">
<div class="field is-grouped is-grouped-right gi-is-grouped-reverse form-actions">
<p class="control" v-if="currentStep !== 0">
<button
class="button is-light is-large"
Expand Down