-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#347 Update Sidebar + Navbar to match designs #390
#347 Update Sidebar + Navbar to match designs #390
Conversation
2a9481c
to
9af2a5c
Compare
9af2a5c
to
b1f7927
Compare
Should this perhaps be fixed before merging?
Sorry, don't understand. What are you trying to do? We can do a video chat if you'd like, and/or ask @hubudibu for help.
Should I review and merge this PR before #387 or after #387? |
Both PR are independent, but if it this one goes after it gets cleaner. |
b1f7927
to
ea74b76
Compare
I'm also not sure what you miss from debugging, but from the top of my head
the template does'nt get translated to JS like the JSX in react, so you can't write plain js in the template tags, that is true. maybe if you give an example on what you would console.log I could help more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge conflict needs fixing
8b3736c
to
c9d8f77
Compare
Fixed @taoeffect 😊 |
Following and Closes #347
I've updated Sidebar and Navbar layout to match the design on #347.
"is-active"
logic isn't working, so any tab is never active, but the design for the class is done. BTW, how can I debug easily a vue component? On react it's easy as{ console.log('x')}
but on Vue I couldn't make it work, neither using breakpoints... What's the trick?Pay Group
link, so to not erase it, I've kept it on navbar until we figure out a better way.Some parts of the layout don't match exactly the design (typography sizes / colors). It only uses bulma classes for now. I believe we can still iterate a lot on the navigation (sidebar + navbar) and elements hierarchy, but let's keep that for another iteration when we have #387 merged. I prefer to have small but fast iterations, what do you think?