Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special exit code for --await CLI commands #2380

Closed
roman-khimov opened this issue Jun 13, 2023 · 0 comments
Closed

Special exit code for --await CLI commands #2380

roman-khimov opened this issue Jun 13, 2023 · 0 comments
Assignees
@AliceInHunterland
Labels
enhancement Improving existing functionality neofs-cli NeoFS CLI application issues
Milestone
v0.38.0

Comments

@roman-khimov
Copy link
Member

Is your feature request related to a problem? Please describe.

I'm always frustrated when some command timeouts and I get some generic exit code returned. It can timeout before receiving "OK" for its request and it can timeout after that while waiting for the intended side effect (--await). Those are quite different situations.

Describe the solution you'd like

A special exit code returned in case the action was requested, but --await loop ended up with timeout.

Additional context

Related to #2135 and #2376.
@roman-khimov roman-khimov added enhancement Improving existing functionality neofs-cli NeoFS CLI application issues labels Jun 13, 2023
@roman-khimov roman-khimov added this to the v0.38.0 milestone Jun 13, 2023
@roman-khimov roman-khimov mentioned this issue Jun 13, 2023
Merged
@cthulhu-rider cthulhu-rider mentioned this issue Aug 2, 2023
Closed
AliceInHunterland added a commit that referenced this issue Aug 14, 2023
@AliceInHunterland
cli: add exit code error for timeout await expiration
4172a2f 
This commit addresses the scenario where a timeout, set by the --await flag,
expires during processing. We now return a new error code specifically for
this case, ErrAwaitTimeout.

Closes #2380.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@AliceInHunterland AliceInHunterland mentioned this issue Aug 14, 2023
Merged
AliceInHunterland added a commit that referenced this issue Aug 14, 2023
@AliceInHunterland
cli: add exit code error for timeout await expiration
78187b5 
This commit addresses the scenario where a timeout, set by the --await flag,
expires during processing. We now return a new error code specifically for
this case, ErrAwaitTimeout.

Closes #2380.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Aug 14, 2023
@AliceInHunterland
cli: add exit code error for timeout await expiration
531ffb1 
This commit addresses the scenario where a timeout, set by the --await flag,
expires during processing. We now return a new error code specifically for
this case, ErrAwaitTimeout.

Closes #2380.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Aug 14, 2023
@AliceInHunterland
cli: add exit code error for timeout await expiration
d91ec90 
This commit addresses the scenario where a timeout, set by the --await flag,
expires during processing. We now return a new error code specifically for
this case, ErrAwaitTimeout.

Closes #2380.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Aug 14, 2023
@AliceInHunterland
cli: add exit code error for timeout await expiration
8653da0 
This commit addresses the scenario where a timeout, set by the --await flag,
expires during processing. We now return a new error code specifically for
this case, ErrAwaitTimeout.

Closes #2380.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Aug 14, 2023
@AliceInHunterland
cli: add exit code error for timeout await expiration
20eaf4e 
This commit addresses the scenario where a timeout, set by the --await flag,
expires during processing. We now return a new error code specifically for
this case, ErrAwaitTimeout.

Closes #2380.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Aug 15, 2023
@AliceInHunterland
cli: add exit code error for timeout await expiration
09c8c03 
This commit addresses the scenario where a timeout, set by the --await flag,
expires during processing. We now return a new error code specifically for
this case, ErrAwaitTimeout.

Closes #2380.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Aug 16, 2023
@AliceInHunterland
cli: add exit code error for timeout await expiration
223d656 
This commit addresses the scenario where a timeout, set by the --await flag,
expires during processing. We now return a new error code specifically for
this case, ErrAwaitTimeout.

Closes #2380.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Aug 16, 2023
@AliceInHunterland
cli: add exit code error for timeout await expiration
54461bd 
This commit addresses the scenario where a timeout, set by the --await flag,
expires during processing. We now return a new error code specifically for
this case, ErrAwaitTimeout.

Closes #2380.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Aug 16, 2023
@AliceInHunterland
cli: add exit code error for timeout await expiration
77a8952 
This commit addresses the scenario where a timeout, set by the --await flag,
expires during processing. We now return a new error code specifically for
this case, ErrAwaitTimeout.

Closes #2380.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Aug 17, 2023
@AliceInHunterland
cli: add exit code error for timeout await expiration
d30ff11 
This commit addresses the scenario where a timeout, set by the --await flag,
expires during processing. We now return a new error code specifically for
this case, ErrAwaitTimeout.

Closes #2380.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Aug 17, 2023
@AliceInHunterland
cli: add exit code error for timeout await expiration
65c5690 
This commit addresses the scenario where a timeout, set by the --await flag,
expires during processing. We now return a new error code specifically for
this case, ErrAwaitTimeout.

Closes #2380.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Aug 17, 2023
@AliceInHunterland
cli: add exit code error for timeout await expiration
d82eb0d 
This commit addresses the scenario where a timeout, set by the --await flag,
expires during processing. We now return a new error code specifically for
this case, ErrAwaitTimeout.

Closes #2380.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Aug 17, 2023
@AliceInHunterland
cli: add exit code error for timeout await expiration
7a21e62 
This commit addresses the scenario where a timeout, set by the --await flag,
expires during processing. We now return a new error code specifically for
this case, ErrAwaitTimeout.

Closes #2380.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Aug 17, 2023
@AliceInHunterland
cli: add exit code error for timeout await expiration
ae1924a 
This commit addresses the scenario where a timeout, set by the --await flag,
expires during processing. We now return a new error code specifically for
this case, ErrAwaitTimeout.

Closes #2380.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Aug 17, 2023
@AliceInHunterland
cli: add exit code error for timeout await expiration
644af01 
This commit addresses the scenario where a timeout, set by the --await flag,
expires during processing. We now return a new error code specifically for
this case, ErrAwaitTimeout.

Closes #2380.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Aug 17, 2023
@AliceInHunterland
neofs-adm:add check for wallet creation
6798a63 
The only command that can create alphabet wallets is init.
The only commands that can create contract wallet are init and update-contracts.

Closes #2380.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland added a commit that referenced this issue Aug 17, 2023
@AliceInHunterland
neofs-adm: add check for wallet creation
5936617 
The only command that can create alphabet wallets is init.
The only commands that can create contract wallet are init and update-contracts.

Closes #2380.

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
roman-khimov added a commit that referenced this issue Aug 18, 2023
@roman-khimov
cli: add exit code error for timeout await expiration (#2501)
e979a59 
A new error code is added for awaiting timeout expiration.
Closes [#2380]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliceInHunterland AliceInHunterland

Labels
enhancement Improving existing functionality neofs-cli NeoFS CLI application issues
Projects
None yet
Milestone
v0.38.0
Development

No branches or pull requests
2 participants
@roman-khimov @AliceInHunterland