cli: add exit code error for timeout await expiration #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2501 +/- ##
=======================================
Coverage 29.68% 29.69%
=======================================
Files 404 404
Lines 30711 30711
=======================================
+ Hits 9117 9119 +2
+ Misses 20825 20823 -2
Partials 769 769
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AliceInHunterland
force-pushed
the
feature/2380-cli-exit-codes
branch
from
4172a2f
to
78187b5
Compare
AliceInHunterland
force-pushed
the
feature/2380-cli-exit-codes
branch
2 times, most recently
from
531ffb1
to
d91ec90
Compare
AliceInHunterland
force-pushed
the
feature/2380-cli-exit-codes
branch
from
d91ec90
to
8653da0
Compare
AliceInHunterland
requested review from
roman-khimov and
carpawell
as code owners
cthulhu-rider
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
LGTM
@roman-khimov do we need an issue to adopt our tests to this behavior?
AliceInHunterland
force-pushed
the
feature/2380-cli-exit-codes
branch
from
8653da0
to
20eaf4e
Compare
|
carpawell
reviewed
Aug 14, 2023
AliceInHunterland
force-pushed
the
feature/2380-cli-exit-codes
branch
3 times, most recently
from
223d656
to
54461bd
Compare
AliceInHunterland
force-pushed
the
feature/2380-cli-exit-codes
branch
2 times, most recently
from
77a8952
to
d30ff11
Compare
AliceInHunterland
force-pushed
the
feature/2380-cli-exit-codes
branch
2 times, most recently
from
65c5690
to
d82eb0d
Compare
roman-khimov
approved these changes
Aug 17, 2023
carpawell
reviewed
Aug 18, 2023
carpawell
reviewed
Aug 18, 2023
This commit addresses the scenario where a timeout, set by the --await flag, expires during processing. We now return a new error code specifically for this case, ErrAwaitTimeout. Closes #2380. Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland
force-pushed
the
feature/2380-cli-exit-codes
branch
from
d82eb0d
to
3b52b93
Compare
carpawell
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new error code is added for awaiting timeout expiration.
Closes [#2380]