Skip to content

[v22.x backport] module: add findPackageJSON util #56494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 188 commits into from
Closed

[v22.x backport] module: add findPackageJSON util #56494

wants to merge 188 commits into from

Conversation

JakobJingleheimer
Copy link
Member

PR-URL: #55412
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com

PR-URL: #55543
Reviewed-By: Jacob Smith jacob@frende.me
Reviewed-By: Marco Ippolito marcoippolito54@gmail.com

PR-URL: #56382
Reviewed-By: Jordan Harband ljharb@gmail.com
Reviewed-By: Geoffrey Booth webadmin@geoffreybooth.com

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Jan 6, 2025
@JakobJingleheimer
Copy link
Member Author

JakobJingleheimer commented Jan 12, 2025 •
edited
Loading

Oh son of a…. Forgot that would break the PR.

@JakobJingleheimer
Copy link
Member Author

@ruyadorno could this land soon before more conflicts arise?

JakobJingleheimer
JakobJingleheimer commented Jan 16, 2025
View reviewed changes
aduh95 and others added 21 commits January 23, 2025 11:00
@aduh95
doc: add history info for Permission Model
e69d35f 
PR-URL: nodejs#56707
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@NathanBaulch @aduh95
doc: fix typos
928540d 
PR-URL: nodejs#55066
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MoLow @aduh95
meta: move MoLow to TSC regular member
9ec67e7 
PR-URL: nodejs#56276
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@joyeecheung @aduh95
build: build v8 with -fvisibility=hidden on macOS
12f716b 
V8 should be built with -fvisibility=hidden, otherwise
the resulting binary would contain unnecessary symbols. In
particular, on macOS, this leads to 5000+ weak symbols
resolved at runtime, leading to a startup regression.

On macOS this also reduces the binary size about ~10MB.

It's only enabled on macOS in this patch as gcc can time out
or run out of memory on some machines in the CI with
-fvisibility=hidden.

PR-URL: nodejs#56275
Fixes: nodejs/performance#180
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@aduh95
doc: fix links in module.md
721104a 
PR-URL: nodejs#56283
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95
test: make test-permission-sqlite-load-extension more robust
a3f5ef2 
PR-URL: nodejs#56295
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
@origranot @aduh95
Revert "events: add hasEventListener util for validate"
9cf9046 
This reverts commit nodejs@bdb6d12.

PR-URL: nodejs#56282
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@origranot @aduh95
test: add test case for listeners
8e149aa 
PR-URL: nodejs#56282
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@lpinca @aduh95
test: deflake test-esm-loader-hooks-inspect-brk
fa56ab2 
Refs: nodejs#54827
Refs: nodejs#51560
PR-URL: nodejs#56050
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@legendecas @aduh95
lib: suppress source map lookup exceptions
df06524 
When the source map data are invalid json strings, skip construct
`SourceMap` on it. Additionally, suppress exceptions on source map
lookups and fix test runners crash on invalid source maps.

PR-URL: nodejs#56299
Refs: nodejs#56296
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
@legendecas @aduh95
lib: optimize prepareStackTrace on builtin frames
dc00321 
Only invalidates source map lookup cache when a new source map is found.
This improves when user codes interleave with builtin functions, like
`array.map`.

PR-URL: nodejs#56299
Refs: nodejs#56296
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
@lpinca @aduh95
test: remove async-hooks/test-writewrap flaky designation
406e7db 
The issue is the same as other tests that time out.

Refs: nodejs#54918
Refs: nodejs#54802
PR-URL: nodejs#56048
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@jazelly @aduh95
stream: validate undefined sizeAlgorithm in WritableStream
e658ea6 
PR-URL: nodejs#56067
Fixes: nodejs#56014
Refs: whatwg/streams#1333
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@vmoroz @aduh95
node-api: remove deprecated attribute from napi_module_register
7245245 
PR-URL: nodejs#56162
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
@targos @aduh95
build: test macos-13 on GitHub actions
2a3cdd3 
We are in the process of updating macOS to version 13 in the
Jenkins CI, but unfortunately this is taking longer than expected.
Add it to the GitHub actions test matrix so that we have some coverage.

Refs: nodejs/build#3686
PR-URL: nodejs#56307
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@legendecas @aduh95
module: use buffer.toString base64
acba5dc 
`btoa` only supports latin-1 charset and produces invalid source
mapping urls.

PR-URL: nodejs#56315
Refs: nodejs#56296
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95
tools: add release line label when opening release proposal
105c4ed 
PR-URL: nodejs#56317
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@zcbenz @aduh95
build: fix GN build for ngtcp2
b197dfa 
PR-URL: nodejs#56300
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95
tools: fix require-common-first lint rule from subfolder
53b29b0 
PR-URL: nodejs#56325
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
@marco-ippolito @aduh95
test: check typescript loader
4352bf6 
PR-URL: nodejs#54657
Refs: nodejs#54645
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@nodejs-github-bot @aduh95
deps: update simdutf to 5.7.0
6eacd19 
PR-URL: nodejs#56332
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
legendecas and others added 11 commits January 31, 2025 11:02
@legendecas @aduh95
tools: update inspector_protocol roller
007fe10 
Fix the inspector_protocol/roll.py to fit node source directory
structure.

`roll.py` reads the `deps/v8/thrid_party/inspector_protocol/README.v8`
to get the revision of the inspector_protocol that V8 depends on, and
updates the local version to match.

V8's copy of inspector_protocol modifies the namespace of `crdtp`
library and does not export the symbols. So it can not be used outside
of V8.

PR-URL: nodejs#56649
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@legendecas @aduh95
inspector: roll inspector_protocol
f2ed5ea 
Roll the inspector_protocol library to match V8's inspector_protocol
revision.

Update the node inspector to use the new `crdtp` protocol library.

PR-URL: nodejs#56649
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@legendecas @aduh95
deps: move inspector_protocol to deps
8f7e6c7 
The `crdtp` library in the inspector_protocol is compiled as a library
and linked to the node executable.

PR-URL: nodejs#56649
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@Trott @aduh95
test: use strict mode in global setters test
04bcebc 
test-global-setters.js was added in
nodejs#26882 and hasn't been modified
since. It appears that it avoids strict mode so that unscoped
identifiers are treated as globals, but that's true in strict mode too.
(In sloppy mode, an assignment to an undefined identifier will create a
global, but that's not what this test does. In strict mode, those
assignments will throw an error, which would seem to be what we would
want.)

PR-URL: nodejs#56742
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@lpinca @aduh95
test: fix invalid common.mustSucceed() usage
88ef806 
By its own nature, the function returned by `common.mustSucceed()`
cannot be used as a listener for `'error'` events.

Write errors like `read ECONNRESET` or `write EPIPE`, should be ignored
because the socket might be closed by the other peer while the request
is sent.

Refs: nodejs@3caa2c1a005652fdb3e8
PR-URL: nodejs#56756
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@lpinca @aduh95
test: reduce number of written chunks
ddb0314 
Reduce chances of write errors while the request is sent.

Refs: nodejs#56756
PR-URL: nodejs#56757
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@mhdawson @aduh95
doc: move anatoli to emeritus
216541c 
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#56592
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
@nodejs-github-bot @aduh95
meta: move one or more collaborators to emeritus
a335914 
PR-URL: nodejs#56580
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@nodejs-github-bot @aduh95
tools: update doc to new version
3cb5297 
PR-URL: nodejs#56259
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@nodejs-github-bot @aduh95
deps: update corepack to 0.31.0
7d54ee2 
PR-URL: nodejs#56795
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@louwers @aduh95
doc: add entry to changelog about SQLite Session Extension
d0f635c 
PR-URL: nodejs#56318
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 2, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 2, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64933/

JakobJingleheimer and others added 3 commits February 3, 2025 11:41
@JakobJingleheimer @aduh95
module: add findPackageJSON util
bc8a4bc 
PR-URL: nodejs#55412
Backport-PR-URL: nodejs#56494
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95
module: simplify findPackageJSON implementation
24f5193 
PR-URL: nodejs#55543
Backport-PR-URL: nodejs#56494
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@JakobJingleheimer @aduh95
module: fix async resolution error within the sync findPackageJSON
4361c48 
PR-URL: nodejs#56382
Backport-PR-URL: nodejs#56494
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@aduh95 aduh95 force-pushed the 22.x/findPackageJSON branch from b9754f4 to 4361c48 Compare February 3, 2025 10:43
@aduh95 aduh95 requested a review from a team as a code owner February 3, 2025 10:43
@aduh95
Copy link
Contributor

aduh95 commented Feb 3, 2025 •
edited
Loading

Landed in e0980fc...b341af0

@aduh95 aduh95 closed this Feb 3, 2025
@JakobJingleheimer JakobJingleheimer deleted the 22.x/findPackageJSON branch February 3, 2025 10:49
aduh95 pushed a commit that referenced this pull request Feb 4, 2025
@JakobJingleheimer @aduh95
module: add findPackageJSON util
1d1f880 
PR-URL: #55412
Backport-PR-URL: #56494
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 added a commit that referenced this pull request Feb 4, 2025
@aduh95
module: simplify findPackageJSON implementation
a9d8702 
PR-URL: #55543
Backport-PR-URL: #56494
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 4, 2025
@JakobJingleheimer @aduh95
module: fix async resolution error within the sync findPackageJSON
b341af0 
PR-URL: #56382
Backport-PR-URL: #56494
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
aduh95 pushed a commit that referenced this pull request Feb 6, 2025
@JakobJingleheimer @aduh95
module: add findPackageJSON util
6d6cffa 
PR-URL: #55412
Backport-PR-URL: #56494
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 added a commit that referenced this pull request Feb 6, 2025
@aduh95
module: simplify findPackageJSON implementation
bbedffa 
PR-URL: #55543
Backport-PR-URL: #56494
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 6, 2025
@JakobJingleheimer @aduh95
module: fix async resolution error within the sync findPackageJSON
1f4f9be 
PR-URL: #56382
Backport-PR-URL: #56494
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito left review comments

@aduh95 aduh95 aduh95 approved these changes

@ruyadorno ruyadorno Awaiting requested review from ruyadorno

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.