module: simplify findPackageJSON implementation
#55543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
module
github-actions
bot
removed
the
request-ci
ljharb
approved these changes
Oct 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55543 +/- ##
==========================================
- Coverage 88.43% 88.32% -0.12%
==========================================
Files 654 654
Lines 187657 187629 -28
Branches 36117 36041 -76
==========================================
- Hits 165951 165718 -233
- Misses 14947 15137 +190
- Partials 6759 6774 +15
|
JakobJingleheimer
approved these changes
Oct 26, 2024
There was a problem hiding this comment.
Thanks! I was gonna do whilst my friend was getting ready this morning ;)
Could you also restore #55412 (review)
I dunno how it got removed.
mertcanaltin
approved these changes
Oct 26, 2024
aduh95
added
the
author ready
|
marco-ippolito
approved these changes
Nov 2, 2024
marco-ippolito
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in c0db893 |
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55543 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95
added a commit
that referenced
this pull request
Nov 5, 2024
PR-URL: #55543 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55543 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
|
This commit does not land cleanly on |
ruyadorno
added
the
backport-requested-v22.x
|
How do I find the commit hash I should use to create the backport? Is it the one in Also, can I combine this backport with the one for #55412, since this is directly dependent/related to that? |
|
You can use the one given on #55543 (comment), or the one that landed on v23.x. It should definitely be combined yes |
JakobJingleheimer
pushed a commit
to JakobJingleheimer/node
that referenced
this pull request
Nov 29, 2024
PR-URL: nodejs#55543 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95
added a commit
to JakobJingleheimer/node
that referenced
this pull request
Dec 10, 2024
PR-URL: nodejs#55543 Backport-PR-URL: nodejs#56074 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> PR-URL: nodejs#55412
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #55412 (comment)