Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attempting to get the chunk size after strategy is cleared #1333

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

domenic
Copy link
Member

@domenic domenic commented Nov 26, 2024

Although a better fix might be to delay size calculation until we've verified that we're not in the erroring or errored states, that has observable differences for certain bad-strategy cases already in the WPT suite, and multiple implementations seem to have converged on this particular fix already.

Closes #1331.

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

Although a better fix might be to delay size calculation until we've verified that we're not in the erroring or errored states, that has observable differences for certain bad-strategy cases already in the WPT suite, and multiple implementations seem to have converged on this particular fix already.

Closes #1331.
@domenic domenic merged commit 86d07e9 into main Nov 27, 2024
3 checks passed
@domenic domenic deleted the fix-null-strategy branch November 27, 2024 04:29
nodejs-github-bot pushed a commit to nodejs/node that referenced this pull request Dec 20, 2024
PR-URL: #56067
Fixes: #56014
Refs: whatwg/streams#1333
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Abort followed by write on WritableStream may invoke a null strategy algorithm
2 participants