Skip to content

Comments

Retry ADMB docker images#552

Merged
e-perl-NOAA merged 94 commits intonmfs-ost:mainfrom
admb-project:main
Feb 13, 2024
Merged

Retry ADMB docker images#552
e-perl-NOAA merged 94 commits intonmfs-ost:mainfrom
admb-project:main

Conversation

@johnoel
Copy link
Contributor

@johnoel johnoel commented Jan 10, 2024

Retry docker targets.

Resolves issue #563

@johnoel
Copy link
Contributor Author

johnoel commented Jan 11, 2024

Almost got it, just the windows build now

@e-perl-NOAA
Copy link
Collaborator

Great! The linux and mac docker images are working on my branch too and that was without these most recent changes so C++ issues might have been a merge conflict error resolution that messed the code up somewhere. For the windows admb docker image, I can't get it to run locally (on a windows machine) either. The error that I get when I do docker pull of the windows image is "image operating system "windows" cannot be used on this platform: operating system is not supported". I wonder if the windows executable can be/needs to be built off a linux image? 🤔

@e-perl-NOAA
Copy link
Collaborator

@johnoel are you still making tweaks are is this ready to be merged now?

@johnoel
Copy link
Contributor Author

johnoel commented Feb 9, 2024

Should be okay to merge, just finding workarounds with GitHub Action.

@e-perl-NOAA
Copy link
Collaborator

Okay, thank you @johnoel. I will merge soon. We are working on an issue with a test model that we have that will disrupt me updating the other github actions/workflows to use the admb docker image. I might go ahead and merge your branch and make the update to some of the workflows or, depending on how long it will take us to get that test model fixed, I will wait to merge this until it's fixed and I can update all the workflows immediately following the merge.

@e-perl-NOAA e-perl-NOAA merged commit 420c71f into nmfs-ost:main Feb 13, 2024
@e-perl-NOAA e-perl-NOAA mentioned this pull request Feb 13, 2024
2 tasks
@e-perl-NOAA
Copy link
Collaborator

@msupernaw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

workflows related to workflows/gh-actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants