Skip to content

[Fix]: Fix workflows to use docker image & fix build-ss3-warnings.yml #563

@e-perl-NOAA

Description

@e-perl-NOAA

Issue description

Need to fix the workflow files after Johnoel's branch is merged. @Rick-Methot-NOAA I added this to the change-log so that we know to include in the next release notes that there is now the capability to compile ss3 using docker.

Summary of issue history, discussion, and major aspects of code development

See PR #552 & PR #561

Items to do

  • Merge @johnoel's admb branch
  • Fix workflows to all use the admb docker image
  • Fix the build-ss3-warnings.yml and the ref file for it with it using the docker imager (the fixes are in the admb-docker-attempt2 branch).
  • Change to create a ss3.exe (including tpl names) across all build files (see work @Rick-Methot-NOAA started on the update-makefile branch)
  • Update any of the contributing material that there is now an option to compile ss3 using docker (if needed)

Does documentation already exist in the SS3 User Manual?

No, the documentation that should be added to the SS3 User Manual pertaining to this issue is provided below.

Documentation to add to the SS3 User Manual OR link to existing documentation

NA (all GitHub actions focused).

Are r4ss changes needed?

No, this issue doesn't require changes to r4ss

Are SSI changes needed?

No, this issue doesn't require changes to SSI

Metadata

Metadata

Assignees

Labels

change loguse for issues that should appear in change logworkflowsrelated to workflows/gh-actions

Type

No type

Projects

Status

Done

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions