-
Notifications
You must be signed in to change notification settings - Fork 20
Closed
Labels
workflowsrelated to workflows/gh-actionsrelated to workflows/gh-actions
Description
Issue description
Thanks to @johnoel, ADMB is now available as a Docker image. I think this means we could replace most of this code for installing ADMB https://github.com/nmfs-stock-synthesis/stock-synthesis/blob/main/.github/workflows/build-ss3.yml#L37-L80 with an updated version that uses the Docker images.
No need to explore this prior to the upcoming SS3 release.
Summary of issue history, discussion, and major aspects of code development
Related to previous changes in workflows that compile SS3 and previous changes among ADMB versions.
Items to do
- Create a branch
- Try changing the workflow files
- See how long the github actions take
- Confirm that model results are the same
Does documentation already exist in the SS3 User Manual?
Yes, the link to the section in the SS3 User Manual is provided below.
Documentation to add to the SS3 User Manual OR link to existing documentation
No change to documentation needed.
Are r4ss changes needed?
No, this issue doesn't require changes to r4ss
Are SSI changes needed?
No, this issue doesn't require changes to SSI
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
workflowsrelated to workflows/gh-actionsrelated to workflows/gh-actions