plugins/lsp: correct motivation for onAttach alias impl
#3297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously I said we alias the definitions instead of the value to allow `mkOrder` to work correctly. That is incorrect, as order-priorities are already sorted in `<opt>.definitions`. The actual reason to use the definitions instead of the final value is to avoid inf-recursion. The "from" option's `apply` function would read the "to" option's value, which is defined based on the "from" option's value, which is set by the "from" option's apply function... For a one-way binding, `mkDerivedConfig` is best. For a two-way binding, `mkAliasAndWrapDefsWithPriority` is necessary.
MattSturgeon
force-pushed
the
plugins/lsp-on-attach-comment
branch
from
f602cea to
10f899d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
This pull request, with head sha This pull request will be automatically closed by GitHub.As soon as GitHub detects that the sha It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has no code changes, but it corrects an incorrect and misleading comment in #3295.
Previously I said we alias the definitions instead of the value to allow
mkOrderto work correctly. That is incorrect, as order-priorities are already sorted in<opt>.definitions.The actual reason to use the definitions instead of the final value is to avoid inf-recursion. The "from" option's
applyfunction reads the "to" option's value, which would be defined based on the "from" option's value, which is set by the "from" option's apply function...For a one-way binding,
mkDerivedConfigis best. For a two-way binding,mkAliasAndWrapDefsWithPriorityis necessary.