Skip to content

plugins/lsp: correct motivation for onAttach alias impl #3297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

plugins/lsp: correct motivation for onAttach alias impl #3297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions plugins/lsp/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,15 +182,9 @@ lib.nixvim.plugins.mkNeovimPlugin {
# `mkAliasAndWrapDefinitions` and `mkAliasAndWrapDefsWithPriority` propagates the un-merged
# `definitions`.
#
# This assumes both options have compatible merge functions, but it allows override and order
# priorities to be merged correctly.
#
# E.g:
# lsp.onAttach = mkAfter "world";
# plugins.lsp.onAttach = mkBefore "hello"
# ⇒
# hello
# world
# This assumes both options have compatible merge functions, but not using the final value allows
# implementing a two-way binding in the option's `apply` function. Using `mkDerivedConfig` for a
# two-way binding would result in infinite recursion.
#
# This is equivalent to `mkAliasOptionModule`, except predicated on `plugins.lsp.enable`.
#
Expand Down