plugins.lsp: alias onAttach to new lsp.onAttach
#3295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattSturgeon
force-pushed
the
plugins/lsp-on-attach
branch
3 times, most recently
from
3d88184 to
dbac55c
Compare
MattSturgeon
commented
May 7, 2025
Comment on lines
-85
to
-93
| # If nvim-lspconfig is enabled: | ||
| (mkIf config.plugins.lsp.enable { | ||
| # Use the same `on_attach` callback as for the other LSP servers | ||
| plugins.rustaceanvim.settings.server.on_attach = mkDefault '' | ||
| function(client, bufnr) | ||
| return _M.lspOnAttach(client, bufnr) | ||
| end | ||
| ''; | ||
| }) |
There was a problem hiding this comment.
The actual change in this file is removing:
# If nvim-lspconfig is enabled:
(mkIf config.plugins.lsp.enable {
# Use the same `on_attach` callback as for the other LSP servers
plugins.rustaceanvim.settings.server.on_attach = mkDefault ''
function(client, bufnr)
return _M.lspOnAttach(client, bufnr)
end
'';
})Otherwise, the large diff is just removing the now-redundent mkMerge, so it may be easier to read with whitespace changes hidden.
This simplifies the impl by doing global on-attach logic in a `LspAttach` autocmd instead of adding lua lines to each server's individual `on_attach` callback. This is effectively a `mkAliasOptionModule` alias, other than the alias only being applied when `plugins.lsp.enable`.
MattSturgeon
force-pushed
the
plugins/lsp-on-attach
branch
from
dbac55c to
5c52e8f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This pull request, with head sha This pull request will be automatically closed by GitHub.As soon as GitHub detects that the sha It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3280
Simplify the impl by doing global on-attach logic in
lsp.onAttach(i.e. aLspAttachautocmd) instead of adding lua lines to each server's individualon_attachcallback function.This is effectively a
mkAliasOptionModule [ "plugins" "lsp" "onAttach" ] [ "lsp" "onAttach" ]alias, but it is only applied whenplugins.lsp.enableis true.