modules/lsp: add onAttach option
#3280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaetanLepage
reviewed
May 4, 2025
This was referenced May 4, 2025
MattSturgeon
force-pushed
the
lsp-on-attach
branch
from
ae8fd97 to
665586f
Compare
Similar to `plugins.lsp.onAttach`, implement a "global" equivalent to the per-server `on_attach` callback. This is implemented using a `LspAttach` autoCmd.
MattSturgeon
force-pushed
the
lsp-on-attach
branch
from
665586f to
2b3daaf
Compare
|
I've added a second commit which refactors #3289 to make use of the new option. Hopefully this demonstrates the usefulness of it? |
MattSturgeon
force-pushed
the
lsp-on-attach
branch
from
2b3daaf to
1ed7754
Compare
MattSturgeon
force-pushed
the
lsp-on-attach
branch
from
1ed7754 to
2ea0131
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
plugins.lsp.onAttach, implement a "global" equivalent to the per-serveron_attachcallback.The implementation is simpler than
plugins.lsp.onAttach, by using aLspAttachautocmd. The old impl was to propagate the global onAttach lines into each server'son_attachcallback.The old impl should be able to migrate to using the new option under the hood, or even become an alias of it.
Alternatively, we might decide we don't want this at all? Although it seems convenient.
Perhaps in future it'd be nice to have a similar per-server
onAttachoption? When the per-serveronAttachoption is defined,settings.on_attachwould be derived from it, using it as the function body.