-
Notifications
You must be signed in to change notification settings - Fork 1
Add the discovery client package to ni-apis-python #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
mjohanse-emr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm leaving this review so there are comments on some of the changes I made after copying the files from measurement-plugin-python. Hopefully the comments are useful.
If any of these changes should not be made, please let me know.
...i.measurementlink.discovery.v1.client/src/ni/measurementlink/discovery/v1/client/__init__.py
Outdated
Show resolved
Hide resolved
...ni.measurementlink.discovery.v1.client/src/ni/measurementlink/discovery/v1/client/_client.py
Show resolved
Hide resolved
...ni.measurementlink.discovery.v1.client/src/ni/measurementlink/discovery/v1/client/_client.py
Show resolved
Hide resolved
packages/ni.measurementlink.discovery.v1.client/tests/unit/test_discovery_client.py
Show resolved
Hide resolved
packages/ni.measurementlink.discovery.v1.client/tests/utilities/fake_rpc_error.py
Show resolved
Hide resolved
...ni.measurementlink.discovery.v1.client/src/ni/measurementlink/discovery/v1/client/_client.py
Outdated
Show resolved
Hide resolved
...i.measurementlink.discovery.v1.client/src/ni/measurementlink/discovery/v1/client/_support.py
Show resolved
Hide resolved
...i.measurementlink.discovery.v1.client/src/ni/measurementlink/discovery/v1/client/_support.py
Show resolved
Hide resolved
|
This package needs to be added to the workflow files to get the checks to run on it. I'm going to wait until @csjall 's PR goes in and I'll add it to the json file. |
...ni.measurementlink.discovery.v1.client/src/ni/measurementlink/discovery/v1/client/_client.py
Outdated
Show resolved
Hide resolved
...i.measurementlink.discovery.v1.client/src/ni/measurementlink/discovery/v1/client/_support.py
Outdated
Show resolved
Hide resolved
...i.measurementlink.discovery.v1.client/src/ni/measurementlink/discovery/v1/client/_support.py
Outdated
Show resolved
Hide resolved
...s/ni.measurementlink.discovery.v1.client/src/ni/measurementlink/discovery/v1/client/_info.py
Outdated
Show resolved
Hide resolved
.../ni.measurementlink.discovery.v1.client/src/ni/measurementlink/discovery/v1/client/_types.py
Show resolved
Hide resolved
jfriedri-ni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...ni.measurementlink.discovery.v1.client/src/ni/measurementlink/discovery/v1/client/_client.py
Outdated
Show resolved
Hide resolved
...ni.measurementlink.discovery.v1.client/src/ni/measurementlink/discovery/v1/client/_client.py
Show resolved
Hide resolved
...ni.measurementlink.discovery.v1.client/src/ni/measurementlink/discovery/v1/client/_client.py
Show resolved
Hide resolved
...ni.measurementlink.discovery.v1.client/src/ni/measurementlink/discovery/v1/client/_client.py
Show resolved
Hide resolved
...ni.measurementlink.discovery.v1.client/src/ni/measurementlink/discovery/v1/client/_client.py
Show resolved
Hide resolved
...s/ni.measurementlink.discovery.v1.client/src/ni/measurementlink/discovery/v1/client/_info.py
Outdated
Show resolved
Hide resolved
...i.measurementlink.discovery.v1.client/src/ni/measurementlink/discovery/v1/client/_support.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
...i.measurementlink.discovery.v1.client/src/ni/measurementlink/discovery/v1/client/_support.py
Show resolved
Hide resolved
...i.measurementlink.discovery.v1.client/src/ni/measurementlink/discovery/v1/client/_support.py
Outdated
Show resolved
Hide resolved
packages/ni.measurementlink.discovery.v1.client/tests/unit/test_discovery_client.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
...i.measurementlink.discovery.v1.client/src/ni/measurementlink/discovery/v1/client/__init__.py
Show resolved
Hide resolved
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
…the run_unit_tests workflow. Signed-off-by: Michael Johansen <michael.johansen@ni.com>
What does this Pull Request accomplish?
ni.measurementlink.discovery.v1.clientthat provides the client interface toni.measurementlink.discovery.v1.proto.DiscoveryClientclass and updated the unit tests to only use the non-deprecated versions. This includes deleting one unit test that was testing the deprecation warning.ServiceInfodefinition from measurement-plugin-python's measurement client folder in this new discovery client package.Why should this Pull Request be merged?
Implements AB#3239055
What testing has been done?
Unit tests, mypy, pyright, styleguide.