Skip to content

Conversation

@dixonjoel
Copy link
Collaborator

@dixonjoel dixonjoel commented Sep 17, 2025

What does this Pull Request accomplish?

Fixes #1226

Adds back in required redirects to client packages from ni-apis-python for modules that were removed.

Why should this Pull Request be merged?

Do not break clients when they upgrade to a new version of ni_measurement_plugin_sdk_service package.

What testing has been done?

Installed all of the examples one-by-one pointing to the local ni_measurement_plugin_sdk_service code. Ensured that there were no broken imports on all of them.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2025

Test Results

    52 files  ±0      52 suites  ±0   1h 15m 21s ⏱️ + 1m 33s
   689 tests ±0     689 ✅ ±0      0 💤 ±0  0 ❌ ±0 
20 700 runs  ±0  19 644 ✅ ±0  1 056 💤 ±0  0 ❌ ±0 

Results for commit d1436d2. ± Comparison against base commit c1954e4.

♻️ This comment has been updated with latest results.

@bkeryan
Copy link
Collaborator

bkeryan commented Sep 17, 2025

Installed all of the examples one-by-one pointing to the local ni_measurement_plugin_sdk_service code. Ensured that there were no broken imports on all of them.

@dixonjoel Did you also run mypy on the examples?

@dixonjoel dixonjoel requested a review from bkeryan September 17, 2025 20:03
@dixonjoel
Copy link
Collaborator Author

Installed all of the examples one-by-one pointing to the local ni_measurement_plugin_sdk_service code. Ensured that there were no broken imports on all of them.

@dixonjoel Did you also run mypy on the examples?

I didn't. But it's run as part of check_examples... which failed with some errors the first run that I subsequently fixed. That's good enough right?

@bkeryan
Copy link
Collaborator

bkeryan commented Sep 17, 2025

Installed all of the examples one-by-one pointing to the local ni_measurement_plugin_sdk_service code. Ensured that there were no broken imports on all of them.

@dixonjoel Did you also run mypy on the examples?

I didn't. But it's run as part of check_examples... which failed with some errors the first run that I subsequently fixed. That's good enough right?

Yes, now that the examples are pointing at main rather than the latest release, that should catch any missing symbols during type checking.

@dixonjoel dixonjoel requested a review from bkeryan September 17, 2025 22:31
Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestion (typo)

@dixonjoel dixonjoel merged commit 3da9aed into main Sep 18, 2025
17 checks passed
@dixonjoel dixonjoel deleted the users/jdixon/fix-client-redirects branch September 18, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Examples Still Reference Deprecated SDK Modules Instead of Migrated ni.measurementlink Package

3 participants