-
Notifications
You must be signed in to change notification settings - Fork 19
Add redirects for modules and classes that were moved to ni-apis-python #1228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
packages/service/ni_measurement_plugin_sdk_service/session_management/_reservation.py
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/discovery/__init__.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/session_management/__init__.py
Show resolved
Hide resolved
@dixonjoel Did you also run mypy on the examples? |
I didn't. But it's run as part of check_examples... which failed with some errors the first run that I subsequently fixed. That's good enough right? |
Yes, now that the examples are pointing at main rather than the latest release, that should catch any missing symbols during type checking. |
packages/service/ni_measurement_plugin_sdk_service/discovery/__init__.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/discovery/__init__.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/grpc/__init__.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/grpc/channelpool/__init__.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/grpc/loggers/__init__.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/measurement/info.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/pin_map/__init__.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/session_management/__init__.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/grpc/channelpool/__init__.py
Outdated
Show resolved
Hide resolved
bkeryan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with suggestion (typo)
What does this Pull Request accomplish?
Fixes #1226
Adds back in required redirects to client packages from ni-apis-python for modules that were removed.
Why should this Pull Request be merged?
Do not break clients when they upgrade to a new version of
ni_measurement_plugin_sdk_servicepackage.What testing has been done?
Installed all of the examples one-by-one pointing to the local
ni_measurement_plugin_sdk_servicecode. Ensured that there were no broken imports on all of them.