Restore session_management module export to service package #1250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeryan
approved these changes
Oct 6, 2025
Collaborator
bkeryan
left a comment
bkeryan
left a comment
There was a problem hiding this comment.
Approved with suggestions
bkeryan
reviewed
Oct 6, 2025
packages/service/ni_measurement_plugin_sdk_service/session_management/_types.py
Show resolved
Hide resolved
Contributor
csjall
approved these changes
Oct 6, 2025
dixonjoel
added a commit
that referenced
this pull request
Oct 6, 2025
* Update examples to >=2.3.1,<4.0 * Restore session_management export from ni_measurement_plugin_sdk_service * Set version numbers to 3.0.1 * Restore _types module with SessionInitializationBehavior * Do not reference private modules from ni_measurement_plugin_sdk_service. * Revert version change so the rest can be cherry picked to main * Restore more exports from _reservation and _types * Fix linter errors
1 task
dixonjoel
added a commit
that referenced
this pull request
Oct 7, 2025
…ort (#1253) Restore session_management module export to service package (#1250) * Update examples to >=2.3.1,<4.0 * Restore session_management export from ni_measurement_plugin_sdk_service * Set version numbers to 3.0.1 * Restore _types module with SessionInitializationBehavior * Do not reference private modules from ni_measurement_plugin_sdk_service. * Revert version change so the rest can be cherry picked to main * Restore more exports from _reservation and _types * Fix linter errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Adds back in the session_management to all in the ni_measurement_plugin_sdk_service. This was removed when we started consuming packages from ni-apis-python (see #1220), but not restored with #1228.
Also updating the examples pyproject.toml to allow version 3.0.
Why should this Pull Request be merged?
Examples are broken when upgrading to the 3.0.0 version.
What testing has been done?
Installed ni_dcpower_source_voltage example with a local 3.0.1 and ensured it ran correctly.