Add discovery annotations as a public subpackage#103
Merged
mjohanse-emr merged 11 commits intomainfrom Sep 8, 2025
Merged
Conversation
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Contributor
added 4 commits
August 28, 2025 14:01
…odegen. Signed-off-by: Michael Johansen <michael.johansen@ni.com>
…ubpackage mode. Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
jfriedri-ni
requested changes
Aug 28, 2025
Collaborator
jfriedri-ni
left a comment
jfriedri-ni
left a comment
There was a problem hiding this comment.
Thanks for the improvements to the generator!
Co-authored-by: Joe F <114173023+jfriedri-ni@users.noreply.github.com>
jfriedri-ni
approved these changes
Aug 28, 2025
bkeryan
requested changes
Aug 28, 2025
...asurementlink.discovery.v1.proto/src/ni/measurementlink/discovery/v1/annotations/__init__.py
Outdated
Show resolved
Hide resolved
...asurementlink.discovery.v1.proto/src/ni/measurementlink/discovery/v1/annotations/__init__.py
Show resolved
Hide resolved
added 2 commits
September 2, 2025 10:35
…to file. Add comments to each constant. Signed-off-by: Michael Johansen <michael.johansen@ni.com>
…ni/ni-apis-python into users/mjohanse/move_annotations
jfriedri-ni
reviewed
Sep 2, 2025
dixonjoel
approved these changes
Sep 3, 2025
added 3 commits
September 4, 2025 15:39
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
Signed-off-by: Michael Johansen <michael.johansen@ni.com>
dixonjoel
approved these changes
Sep 5, 2025
bkeryan
approved these changes
Sep 5, 2025
Collaborator
bkeryan
left a comment
bkeryan
left a comment
There was a problem hiding this comment.
The discovery annotations look good to me.
bkeryan
reviewed
Sep 5, 2025
mjohanse-emr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Adds annotation string constants as a public subpackage of
ni.measurementlink.discovery.v1.protoso they can be used by both server and client packages.In order to allow for a "non-generated" subpackage, I made some updates to
grpc_generatorto only cleanup directories that end in "_pb2" or "_pb2_grpc". Any other directory is assumed to be non-generated and won't be deleted at codegen time.See this PR comment for more context:
#93 (comment)
Why should this Pull Request be merged?
Implements #97
What testing has been done?