-
Notifications
You must be signed in to change notification settings - Fork 964
Add new module stainwarpy/register #9777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
b288e0b to
7f2b6e2
Compare
7f2b6e2 to
55ed252
Compare
SPPearce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the module makes fixed name files?
Does the tool take a prefix at all, or could we rename the files afterwards?
317b87e to
b561be1
Compare
| then { | ||
| { assert snapshot( | ||
| process.out.reg_image, | ||
| process.out.reg_metrics_tform, | ||
| process.out.tform_map, | ||
| process.out.findAll { key, val -> key.startsWith("versions")} | ||
| ).match() } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| then { | |
| { assert snapshot( | |
| process.out.reg_image, | |
| process.out.reg_metrics_tform, | |
| process.out.tform_map, | |
| process.out.findAll { key, val -> key.startsWith("versions")} | |
| ).match() } | |
| } | |
| then { | |
| { assert snapshot(process.out).match() } | |
| } |
This doesn't have the assert process.success?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added assert process.success as suggested. And for the snapshot, snapshotting process.out directly caused nf-test to fail with a “no output channels” error.
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
e65bc86 to
4386ecd
Compare
This PR adds,
stainwarpy
modules for registration of H&E tissue images with their corresponding multiplexed images and to transform the segmentation masks of one image type to be able to use with the other type.
Note: output files are non-deterministic between runs due to metadata (ef: UUIDs) and minor floating-point differences.
PR checklist
Closes #9702
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda