Skip to content

Conversation

@edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller commented Jun 2, 2025

Until we can work out a better "skip" if the build is failing mechanism.

Currently, all of the tests that fail are resulting in a large number of "failed" build requests on the wave side, instead of just passing an already made container.

Until we can work out a better "skip" if the build is failing mechanism
@mashehu
Copy link
Contributor

mashehu commented Jun 2, 2025

What is the problem with the current setup?

@edmundmiller
Copy link
Contributor Author

What is the problem with the current setup?

Currently, all of the tests that fail result in a large number of "failed" build requests on the wave side instead of just passing an already-made container.

So it's just wasting a bunch of compute trying to build containers that we know are failing.

@edmundmiller edmundmiller added this pull request to the merge queue Jun 2, 2025
Merged via the queue into master with commit 449f4cf Jun 2, 2025
14 checks passed
@edmundmiller edmundmiller deleted the turn-arm-off branch June 2, 2025 17:46
@ewels
Copy link
Member

ewels commented Jun 2, 2025

To quote an @edmundmiller Slack classic:

Like we can build out "Hey this package failed to build, if arm-failure.txt exists in the module directory, don't run arm wave request, and don't run arm CI" until we remove the txt

I think this is nice solution ☝🏻 Otherwise yeah, we're just running builds on a bunch of containers for every unrelated commit for basically no reason. Adding a file there would prevent that and hopefully annoy people a bit more and actually make folks more likely to try to fix stuff 😅

famosab pushed a commit to famosab/modules that referenced this pull request Jun 3, 2025
Until we can work out a better "skip" if the build is failing mechanism
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants