Skip to content

Capture ABRA2 BAI outputs and stabilise snapshots - #13058

Closed
Lukecele with Copilot wants to merge 4 commits into
masterfrom
copilot/fix-failing-github-actions-job
Closed

Lukecele with Copilot wants to merge 4 commits into
masterfrom
copilot/fix-failing-github-actions-job

Conversation

Copilot AI commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Conda nf-tests failed because ABRA2’s BAI checksums differ from the shared snapshot across execution profiles. ABRA2 emits *.bai, not only *.bam.bai.

  • Output contract: Match *.bai in the module and metadata so real index files are emitted.
  • Snapshots: Compare BAI filenames without profile-dependent checksums; retain BAM read-content checks.
tuple val(meta), path("*.bai"), emit: bai, optional: true

Co-authored-by: Lukecele <87429074+Lukecele@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job 'Run nf-test / x64 | conda | 6' Capture ABRA2 BAI outputs and stabilise snapshots Sep 29, 2026
Copilot AI requested a review from Lukecele September 29, 2026 22:16
@Lukecele
Lukecele marked this pull request as ready for review September 29, 2026 22:20
@Lukecele
Lukecele enabled auto-merge September 29, 2026 22:25
@Lukecele
Lukecele disabled auto-merge September 29, 2026 22:25
@Lukecele Lukecele mentioned this pull request Sep 30, 2026
4 tasks done
@Lukecele

Lukecele commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Closing this PR as a duplicate of #13039, which has now been merged.

The merged PR includes the *.bai output pattern and the profile-independent snapshot handling needed for ABRA2. The final nf-test, lint, Conda, Docker, and Singularity checks passed; GPU jobs were correctly skipped because this module has no GPU-tagged tests.

Thanks to everyone who contributed to validating and stabilising the fix.

@Lukecele Lukecele closed this Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants