You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-up pushed in 774206f. This addresses the local/CI issues I could reproduce: versions.yml now broadcasts to topic: versions, the Zarr fixture metadata files have final newlines for pre-commit, and the h5ad test now checks output presence/content instead of MD5 snapshots that differ across runtimes.\n\nLocal validation passed on 2026-05-19:\n- conda run -n nfcore-topic nf-core modules lint scanpy/pca --local --plain-text\n- conda run -n nfcore-topic prek run --files $(git diff --name-only)\n- conda run -n nfcore-topic nf-test test modules/nf-core/scanpy/pca/tests/main.nf.test --profile docker --filter process --verbose\n- conda run -n nfcore-topic nf-test test modules/nf-core/scanpy/pca/tests/main.nf.test --profile conda --filter process --verbose\n- git diff --check\n\nThe GitHub workflow runs for this new commit currently show action_required before jobs start, so a maintainer may need to approve them when convenient.
Update: rebased this PR onto current nf-core/modules:master and marked it ready for review. Latest head is 71bbc5a11.\n\nFresh local validation after the rebase:\n- conda run -n nfcore-topic nf-core modules lint scanpy/pca --local --plain-text\n- conda run -n nfcore-topic prek run --files $(git diff --name-only upstream/master...HEAD)\n- conda run -n nfcore-topic nf-test test modules/nf-core/scanpy/pca/tests/main.nf.test --profile docker --filter process --verbose\n- git diff --check\n\nThe GitHub workflows are still awaiting maintainer approval before they can run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Part of #11559
This PR adds Zarr input/output support to
scanpy/pcaas a first scverse module slice.Changes:
.zarrinputs and emit a matching.zarrAnnData output directory..h5adbehavior for.h5adinputs.zarras an optional output channel and document it inmeta.yml.versions.ymlontopic: versions.scanpyin the stub version command by usingimportlib.metadata.version("scanpy").Validation run locally on 2026-05-19:
conda run -n nfcore-topic nf-core modules lint scanpy/pca --local --plain-textconda run -n nfcore-topic prek run --files $(git diff --name-only)conda run -n nfcore-topic nf-test test modules/nf-core/scanpy/pca/tests/main.nf.test --profile docker --filter process --verboseconda run -n nfcore-topic nf-test test modules/nf-core/scanpy/pca/tests/main.nf.test --profile conda --filter process --verbosegit diff --checkThis comment contains a description of changes (with reason).
If you've fixed a bug or added code that should be tested, add tests!
If you've added a new tool - have you followed the module conventions in the contribution docs
If necessary, include test data in your PR.
Remove all TODO statements.
Broadcast software version numbers to
topic: versions- See version_topicsFollow the naming conventions.
Follow the parameters requirements.
Follow the input/output options guidelines.
Add a resource
labelUse BioConda and BioContainers if possible to fulfil software requirements.
Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
nf-core modules test scanpy/pca --profile dockernf-core modules test scanpy/pca --profile singularitynf-core modules test scanpy/pca --profile conda