Skip to content

fix: use appropriate user agent string when syncing Outlook calendar subscriptions #54575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2025
Merged

fix: use appropriate user agent string when syncing Outlook calendar subscriptions #54575

merged 1 commit into from
Aug 22, 2025

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Aug 22, 2025 •
edited
Loading

Summary

Imported from #54564

Some Outlook tenants block our user agent when syncing calendar subscriptions. Hence, we need to fake a Chrome browser.

For the investigation please have a look at bitfireAT/icsx5#654 (comment)

Checklist

@st3iny st3iny added this to the Nextcloud 32 milestone Aug 22, 2025
@st3iny st3iny self-assigned this Aug 22, 2025
@st3iny st3iny added the bug label Aug 22, 2025
@st3iny st3iny added the 3. to review Waiting for reviews label Aug 22, 2025
@st3iny st3iny requested a review from tcitworld as a code owner August 22, 2025 07:17
@st3iny st3iny added the feature: caldav Related to CalDAV internals label Aug 22, 2025
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 💌 📅 👥 Groupware team Aug 22, 2025
@st3iny st3iny mentioned this pull request Aug 22, 2025
Closed
4 tasks
@st3iny
Copy link
Member Author

st3iny commented Aug 22, 2025

/backport to stable31

@st3iny
Copy link
Member Author

st3iny commented Aug 22, 2025

/backport to stable30

ChristophWurst
ChristophWurst approved these changes Aug 22, 2025
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@st3iny st3iny enabled auto-merge August 22, 2025 14:37
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 22, 2025
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 22, 2025
Merged
@bmajik @AndyScherzinger
fix: use appropriate user agent string when syncing Outlook calendar …
4d770f1 
…subscriptions

Signed-off-by: Matt Evans <matt@mattevans.org>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny merged commit 01c6095 into master Aug 22, 2025
223 of 231 checks passed
@st3iny st3iny deleted the fix/outlook-user-agent branch August 22, 2025 21:03
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Aug 22, 2025
This was referenced Aug 22, 2025
Merged
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 25, 2025
Merged
This was referenced Sep 2, 2025
Closed
Closed
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@kesselb kesselb kesselb approved these changes

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski is a code owner

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

Assignees

@st3iny st3iny

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: caldav Related to CalDAV internals

Projects

💌 📅 👥 Groupware team
Status: ☑️ Done

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

Can't url import Office365 ics calendar

6 participants

@st3iny @ChristophWurst @kesselb @skjnldsv @bmajik