WIP: nextcloud-calendar/#7234 [not tested]

[bmajik]

• Resolves: Can't url import Office365 ics calendar calendar#7234

Summary

In Nextcloud/calendar/7234, users observe that downloading public ICS feeds from some Office365 tenants started returning HTTP 500. In further testing, it was observed that Microsoft is now parsing the HTTP UserAgent request header and looking for certain values. The NextCloud WebDAV module was sending a reasonable UserAgent string, but not one that some Microsoft O365 tenants would accept.

TODO

• I don't have an NC build/test environment setup yet. And I am not a php Developer. So this code might be embarassingly broken :)

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[st3iny]

Thank you very much for the contribution!

Is kind of hacky but I see the problem. Looks good otherwise.

Did not test yet, though.

[st3iny]

You don't have to implement my feedback. We have to import the pull request anyway to make the CI run.

[st3iny]

I tried to test but at least for my personal Outlook, no user agent string was blocked.

So, I trust that you tested the provided string with a restrictive tenant.

[st3iny]

Continued here #54575

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)