Skip to content

fix: use appropriate user agent string when syncing Outlook calendar subscriptions #54575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2025
Merged

fix: use appropriate user agent string when syncing Outlook calendar subscriptions #54575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion apps/dav/lib/CalDAV/WebcalCaching/Connection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,24 @@ public function queryWebcalFeed(array $subscription): ?string {
return null;
}

// ICS feeds hosted on O365 can return HTTP 500 when the UA string isn't satisfactory
// Ref https://github.com/nextcloud/calendar/issues/7234
$uaString = 'Nextcloud Webcal Service';
if (parse_url($url, PHP_URL_HOST) === 'outlook.office365.com') {
// The required format/values here are not documented.
// Instead, this string based on research.
// Ref https://github.com/bitfireAT/icsx5/discussions/654#discussioncomment-14158051
$uaString = 'Nextcloud (Linux) Chrome/66';
}

$allowLocalAccess = $this->config->getValueString('dav', 'webcalAllowLocalAccess', 'no');

$params = [
'nextcloud' => [
'allow_local_address' => $allowLocalAccess === 'yes',
],
RequestOptions::HEADERS => [
'User-Agent' => 'Nextcloud Webcal Service',
'User-Agent' => $uaString,
'Accept' => 'text/calendar, application/calendar+json, application/calendar+xml',
],
];
Expand Down
Loading