Skip to content

fix: hide guests group from overall principals #54167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

fix: hide guests group from overall principals #54167

merged 1 commit into from
Jul 31, 2025

Conversation

@nilsding
Copy link
Member

@nilsding nilsding commented Jul 31, 2025 •
edited by kesselb
Loading

Resolves #52958
Resolves nextcloud/calendar#7161
Resolves nextcloud/guests#1359

Summary

Follow-up for #52914 and #53369

Checklist

@nilsding
fix: hide guests group from overall principals
45c8664 
Follow-up for #52914 and #53369

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
@nilsding nilsding added this to the Nextcloud 32 milestone Jul 31, 2025
@nilsding nilsding requested a review from kesselb July 31, 2025 09:31
@nilsding nilsding self-assigned this Jul 31, 2025
@nilsding nilsding requested a review from a team as a code owner July 31, 2025 09:31
@nilsding nilsding removed the request for review from a team July 31, 2025 09:31
@nilsding nilsding added the bug label Jul 31, 2025
@kesselb
Copy link
Collaborator

kesselb commented Jul 31, 2025

/backport to stable31

@kesselb
Copy link
Collaborator

kesselb commented Jul 31, 2025

/backport to stable30

This was referenced Jul 31, 2025
Closed
Closed
st3iny
st3iny approved these changes Jul 31, 2025
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@st3iny st3iny added the 4. to release Ready to be released and/or waiting for tests to finish label Jul 31, 2025
@st3iny st3iny enabled auto-merge July 31, 2025 10:26
@kesselb kesselb disabled auto-merge July 31, 2025 12:38
@kesselb kesselb merged commit bcfb010 into master Jul 31, 2025
259 of 274 checks passed
@kesselb kesselb deleted the bug/noid/principal-guest_app-not-found-pt2 branch July 31, 2025 12:38
@welcome
Copy link

welcome bot commented Jul 31, 2025

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

This was referenced Jul 31, 2025
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@st3iny st3iny st3iny approved these changes

@kesselb kesselb kesselb approved these changes

@provokateurin provokateurin provokateurin approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski

Assignees

@nilsding nilsding

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

calendar not loading for guests Access to shared calendar not working anymore [Bug]: GroupPrincipalBackend ignores IHideFromCollaborationBackend

6 participants

@nilsding @kesselb @st3iny @provokateurin @skjnldsv