Merge pull request #54167 from nextcloud/bug/noid/principal-guest_app-not-found-pt2

kesselb · web-flow · commit bcfb010e0765 · 2025-07-31T14:38:24.000+02:00
fix: hide guests group from overall principals
diff --git a/apps/dav/lib/Connector/Sabre/Principal.php b/apps/dav/lib/Connector/Sabre/Principal.php
@@ -186,6 +186,9 @@ public function getGroupMembership($principal, $needGroups = false) {
 		if ($this->hasGroups || $needGroups) {
 			$userGroups = $this->groupManager->getUserGroups($user);
 			foreach ($userGroups as $userGroup) {
+				if ($userGroup->hideFromCollaboration()) {
+					continue;
+				}
 				$groups[] = 'principals/groups/' . urlencode($userGroup->getGID());
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -186,6 +186,9 @@ public function getGroupMembership($principal, $needGroups = false) {`
`186`	`186`	`if ($this->hasGroups \|\| $needGroups) {`
`187`	`187`	`$userGroups = $this->groupManager->getUserGroups($user);`
`188`	`188`	`foreach ($userGroups as $userGroup) {`
	`189`	`+ if ($userGroup->hideFromCollaboration()) {`
	`190`	`+ continue;`
	`191`	`+ }`
`189`	`192`	`$groups[] = 'principals/groups/' . urlencode($userGroup->getGID());`
`190`	`193`	`}`
`191`	`194`	`}`