Enable HMR depending on debug mode #43601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonas Heinrich <heinrich@synyx.de>
skjnldsv
reviewed
Feb 23, 2024
| @@ -74,6 +74,17 @@ public function afterController($controller, $methodName, Response $response): R | |||
| $defaultPolicy->useJsNonce($this->csrfTokenManager->getToken()->getEncryptedValue()); | |||
| } | |||
|
|
|||
| // Loosen security presets in debug mode to enable development | |||
| // tools functionality | |||
| $debugging = \OC::$server->getConfig()->getSystemValue('debug', false); | |||
There was a problem hiding this comment.
please use dependency injection in the construct :)
\OC::$server->getConfig() is deprecated
This was referenced Mar 12, 2024
Merged
Merged
Merged
ChristophWurst
requested changes
Jul 4, 2024
would it be possible to introduce an extra system setting variable like "enable_hmr" which can be only enabled if debug mode is also enabled? |
|
HMR requires connection to only one server on a specific host. A proper solution would be to fix only required restrictions for a specific dev server and not to disable CSP completely. |
|
I'd personally prefer to have a solution in a separated app, not in the server. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently Nextlouc needs to get patched to use Vue Devtools due to "hot module reloading" is restricted, see
This PR loosens security on debug mode and makes Vue Devtools usable
Checklist