Skip to content

Enable HMR depending on debug mode #43601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
onny wants to merge 2 commits into from
Closed

Enable HMR depending on debug mode #43601

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d1ca95
Enable HMR depending on debug mode
Feb 22, 2024
f42107f
Merge branch 'master' into hmr_enable
onny Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions lib/private/AppFramework/Middleware/Security/CSPMiddleware.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,17 @@ public function afterController($controller, $methodName, Response $response): R
$defaultPolicy->useJsNonce($this->csrfTokenManager->getToken()->getEncryptedValue());
}

// Loosen security presets in debug mode to enable development
// tools functionality
$debugging = \OC::$server->getConfig()->getSystemValue('debug', false);
Copy link
Member

@skjnldsv skjnldsv Feb 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use dependency injection in the construct :)
\OC::$server->getConfig() is deprecated

if ($debugging) {
// Allow vue dev tool to work on Firefox.
$defaultPolicy->allowEvalScript(true);
// Unblock HMR requests.
$defaultPolicy->addAllowedConnectDomain('*');
$defaultPolicy->addAllowedScriptDomain('*');
}

$response->setContentSecurityPolicy($defaultPolicy);

return $response;
Expand Down