Skip to content

Conversation

Altahrim
Copy link
Collaborator

@Altahrim Altahrim commented Mar 20, 2024

Pending PRs:

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@ASerbinski
Copy link
Contributor

@nickvergessen @AndyScherzinger @szaimen @blizzz @kesselb or anybody else; I've had #32631 open since before NC25 and it keeps getting bumped to the next version without explanation. As far as I've been made aware, its ready to be included. When can I expect it to finally be merged?

@AndyScherzinger
Copy link
Member

@ASerbinski I'll ask @sorbaugh to coordinate efforts on getting it in, if as you say it is good to go.

@ASerbinski
Copy link
Contributor

Thank you @AndyScherzinger !

Like I said, as far as I understand, its ready. I have implemented all of the directions I've been given to that effect.

@AndyScherzinger
Copy link
Member

@ASerbinski let'S see, fingers crossed. A lot of GH actions turned red, so I restarted them, can't tell why 30+ actions failed...

@ASerbinski
Copy link
Contributor

@AndyScherzinger looks like 6 failing now, and they don't seem to be related to my PR. Stuff about sqlite and oracle, which my PR doesn't have any relation to.

@ChristophWurst
Copy link
Member

ChristophWurst commented Mar 21, 2024

Must have PRs

Nice to have PRs

@Altahrim Altahrim added this to the Nextcloud 29 milestone Mar 21, 2024
@Altahrim Altahrim merged commit 5ca6249 into master Mar 21, 2024
@Altahrim Altahrim deleted the release/29.0.0_beta_5 branch March 21, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants