Skip to content

[stable19] fix sharer flag on ldap:show-remnants when user owned more than a single share #23708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 27, 2020
Merged

[stable19] fix sharer flag on ldap:show-remnants when user owned more than a single share #23708

merged 3 commits into from
Oct 27, 2020

Conversation

@backportbot-nextcloud
Copy link

backport of #23702

blizzz added 3 commits October 27, 2020 08:49
@blizzz @backportbot
add test for active shares flag
394ec56 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz @backportbot
split instantiation from business logic in OfflineUser
7544f0c 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz @backportbot
fixes determining whether former user is a share owner
9c5bd23 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 19.0.5 milestone Oct 27, 2020
@blizzz blizzz changed the title [stable19] [stable20] fix sharer flag on ldap:show-remnants when user owned more than a single share [stable19] fix sharer flag on ldap:show-remnants when user owned more than a single share Oct 27, 2020
@MorrisJobke MorrisJobke added the 4. to release Ready to be released and/or waiting for tests to finish label Oct 27, 2020
@faily-bot
Copy link

faily-bot bot commented Oct 27, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34595: failure

mariadb10.1-php7.2

Show full log 
There was 1 error:

1) Test\Comments\ManagerTest::testDeleteCommentsAtObject
InvalidArgumentException: IDs must be translatable to a number in this implementation.

/drone/src/lib/private/Comments/Manager.php:248
/drone/src/tests/lib/Comments/ManagerTest.php:664

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

@MorrisJobke MorrisJobke mentioned this pull request Oct 27, 2020
Closed
@MorrisJobke MorrisJobke merged commit 9007a8a into stable19 Oct 27, 2020
@MorrisJobke MorrisJobke deleted the backport/23702/stable19 branch October 27, 2020 12:52
@rullzer rullzer mentioned this pull request Nov 9, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz blizzz approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@rullzer rullzer Awaiting requested review from rullzer

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: ldap

Projects

None yet

Milestone

Nextcloud 19.0.5

Development

Successfully merging this pull request may close these issues.

4 participants

@blizzz @skjnldsv @MorrisJobke