[stable20] fix sharer flag on ldap:show-remnants when user owned more than a single share #23702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
requested review from
MorrisJobke,
nickvergessen,
rullzer and
skjnldsv
|
/backport to stable19 |
|
/backport to stable18 |
skjnldsv
approved these changes
Oct 27, 2020
This was referenced Oct 27, 2020
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little sibling of #23700 for Nextcloud 20 and below.
Fixes the condition and stupid DB query. But also adds a unit tests which requires the business logic being drawn out of OfflineUser's constructor, which was bad style anyhow.
Previously, if you had a gone LDAP user owning two or more shares, the "Sharer" flag in the table output would say N(o) instead of Y(es). Unit test added.