Look into unstable tests

[MorrisJobke]

Those tests fail from time to time:

#23437 & #23567 & #23626 & #23729 & #23752 & #23204:

1) OCA\Files_Sharing\Tests\EtagPropagationTest::testReshareRecipientWritesToReshare
Error: Call to a member function getMountPoint() on null

/drone/src/lib/private/Share20/Manager.php:304
/drone/src/lib/private/Share20/Manager.php:705
/drone/src/apps/files_sharing/tests/EtagPropagationTest.php:94
/drone/src/apps/files_sharing/tests/PropagationTestCase.php:42

1) OCA\Files_Versions\Tests\VersioningTest::testRestoreMovedShare
File content has not changed
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'version 2'
+'version 1'

/drone/src/apps/files_versions/tests/VersioningTest.php:729

1) OCA\FederatedFileSharing\Tests\FederatedShareProviderTest::testGetSharedBy
OCP\Share\Exceptions\ShareNotFound: There was an error retrieving the share. Maybe the link is wrong, it was unshared, or it was deleted.

/drone/src/apps/federatedfilesharing/lib/FederatedShareProvider.php:863
/drone/src/apps/federatedfilesharing/lib/FederatedShareProvider.php:242
/drone/src/apps/federatedfilesharing/tests/FederatedShareProviderTest.php:524

1) Test\Files\ObjectStore\ObjectStoreStorageTest::testCopyOverwrite with data set #5 ('/sòurcē.txt', '/target.txt')
Expected /target.txt to be a copy of /drone/src/tests/data/lorem.txt
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.\n
-Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.\n
-Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.\n
-Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.'
+''

/drone/src/tests/lib/Files/Storage/Storage.php:222
/drone/src/tests/lib/Files/Storage/Storage.php:263

1) OCA\DAV\Tests\unit\CardDAV\CardDavBackendTest::testSearch with data set "check if duplicates are handled correctly" ('John', array('FN', 'CLOUD'), array(), array(array('uri0', 'John Doe'), array('uri1', 'John M. Doe')))
108	Failed asserting that 1 is identical to 2.
109	
110	/drone/src/apps/dav/tests/unit/CardDAV/CardDavBackendTest.php:746

OCA\FederatedFileSharing\Tests\FederatedShareProviderTest::testGetSharedByWithLimit
98	OCP\Share\Exceptions\ShareNotFound: There was an error retrieving the share. Maybe the link is wrong, it was unshared, or it was deleted.
99	
100	/drone/src/apps/federatedfilesharing/lib/FederatedShareProvider.php:865
101	/drone/src/apps/federatedfilesharing/lib/FederatedShareProvider.php:244
102	/drone/src/apps/federatedfilesharing/tests/FederatedShareProviderTest.php:655

We should make them more reliable to avoid false positives.

cc @nickvergessen @kesselb @ChristophWurst @rullzer

[MorrisJobke]

✅ disabled in #23492

#23402:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #155 ('folder', 11, 9)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:367

#23422:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #164 ('folder', 13, 5)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:367

#23446:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #248 ('folder', 31, 15)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:367

#23466:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #7 ('file', 17, 3)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:367

#23466:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #93 ('folder', 19, 23)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:367

#15999:

2) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #26 ('folder', 1, 31)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:367

[MorrisJobke]

#23405, #23437:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #243 ('folder', 31, 21)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:361

[MorrisJobke]

#23395:

There was 1 failure:

1) Test\Files\Cache\CacheTest::testSimple
Failed asserting that 0 matches expected 66.

/drone/src/tests/lib/Files/Cache/CacheTest.php:70

[MorrisJobke]

I will keep track which one happens how often and on the third strike it gets disabled.

[MorrisJobke]

#23410 & #23401 & #23336:

tests/acceptance/features/apps.feature:34

 Scenario: Browse app bundles                           # /drone/src/tests/acceptance/features/apps.feature:34
    Given I act as Jane                                  # ActorContext::iActAs()
    And I am logged in as the admin                      # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the Apps management                       # SettingsMenuContext::iOpenTheAppsManagement()
    When I open the "App bundles" section                # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "App bundles" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    And I see the app bundles                            # AppsManagementContext::iSeeTheAppBundles()
      Row for app Auditing / Logging in Apps Management could not be found after 20 seconds (NoSuchElementException)
    And I see that the "Enterprise bundle" is disabled   # AppsManagementContext::iSeeThatTheIsDisabled()

[MorrisJobke]

#23424 & #23621 & #23680:

1) Test\Files\Cache\UpdaterLegacyTest::testWrite
Failed asserting that 1602612817 is equal to 1602612818 or is greater than 1602612818.

/drone/src/tests/lib/Files/Cache/UpdaterLegacyTest.php:118

other output:


Failed asserting that 1603365292 is equal to 1603365293 or is greater than 1603365293.
Failed asserting that 1603650101 is equal to 1603650102 or is greater than 1603650102.

[MorrisJobke]

#23420 & #23479:

tests/acceptance/features/header.feature:57

  Scenario: search for other users in the contacts menu                              # /drone/src/tests/acceptance/features/header.feature:57
    Given I am logged in as the admin                                                # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                                     # SettingsMenuContext::iOpenTheUserSettings()
    And I click the New user button                                                  # UsersSettingsContext::iClickTheNewUserButton()
      New user button in Users Settings could not be found (NoSuchElementException)
    And I see that the new user form is shown                                        # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
    And I create user user1 with password 123456acb                                  # UsersSettingsContext::iCreateUserWithPassword()
    And I see that the list of users contains the user user1                         # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    And I open the Contacts menu                                                     # ContactsMenuContext::iOpenTheContactsMenu()
    And I see that the Contacts menu is shown                                        # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
    And I see that the contact "user0" in the Contacts menu is shown                 # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
    And I see that the contact "user1" in the Contacts menu is shown                 # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
    And I see that the Contacts menu search input is shown                           # ContactsMenuContext::iSeeThatTheContactsMenuSearchInputIsShown()
    When I search for the user "user0"                                               # ContactsMenuContext::iSearchForTheUser()
    Then I see that the contact "user1" in the Contacts menu is eventually not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsEventuallyNotShown()
    And I see that the contact "user0" in the Contacts menu is shown                 # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
    And I see that the contact "admin" in the Contacts menu is not shown             # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()